Scramble order of operations of flutter.gradle#111747
Scramble order of operations of flutter.gradle#111747auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Maybe I'm misremembering, but wasn't it pointing to a line that was adding to a collection? That could certainly involve a sort operation. |
|
@stuartmorgan should we try this? I have no context on if it could help. |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
I'm okay with trying it, but I don't really see how it could help.
GaryQian
added
the
autosubmit
3 participants
#103230 sees strange
Comparison method violates its general contracterrors within gradle. The line pointed to does not seem to be able to cause this unless it is internally within gradle/groovy assignment. This is a rare flake with no clear cause.This PR simply harmlessly shifts the bits around to see if it helps in reducing flake rate.
This does not make any logical changes to the script.