Avoid sending zero transform semantic nodes to the engine#111843
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Sep 19, 2022
Merged
Avoid sending zero transform semantic nodes to the engine#111843auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: accessibility
dnfield
added
the
autosubmit
Contributor
Author
|
I plan to file a CP request for this as well. |
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Sep 19, 2022
itsjustkevin
pushed a commit
that referenced
this pull request
Sep 20, 2022
This was referenced Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses framework side of #110671
We should still fix this on the engine side - it's valid (but inefficient) for someone to send up a zero transform to the engine.