[framework] avoid compositing with visibility#111844
[framework] avoid compositing with visibility#111844auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
| // found in the LICENSE file. | ||
|
|
||
| import 'package:flutter/foundation.dart'; | ||
| import 'package:flutter/rendering.dart'; |
There was a problem hiding this comment.
The overall class comment below still mentions that this may use the Opacity widget behind the scenes. Maybe update that? We should probably still link to the Opacity widget in the see also section, though.
There was a problem hiding this comment.
Same fro the class comment on SliverVisibility
There was a problem hiding this comment.
I do see links to the Opacity/SliverOpacity widgets, but I can't see any comments that directly state that this uses opacity
There was a problem hiding this comment.
I interpreted "These widgets provide some of the facets of this one:" as such. But I don't feel strongly about this comment.
There was a problem hiding this comment.
I think I still want to link to those widgets, I don't see that as necessarily claiming the implementation uses Opacity but providing a hint on a similar way to achieve the same effect.
jonahwilliams
added
the
autosubmit
2 participants
When maintaining state with the
Visibility/SliverVisibilitywidgets, the framework uses anOpacity/SliverOpacitywidget. Unfortunately since we've started preserving the opacity layer at fully opaque, this is no longer free and forces additional compositing.Add new special purpose visibility widgets that do not force compositing