Change type in ImplicitlyAnimatedWidget to remove type cast to improve performance and style#111849
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ImplicitlyAnimatedWidget to remove type cast to improve performance and style
|
@fzyzcjy I believe this just needs a test (or probably just a test exemption) to land. |
|
@goderbauer I agree. Not sure how it can be tested though, so I will ask a test-exempt. I will do it maybe a few days later since I am working on #101227 (and on discord), and do not want to have too many things on discord in one day :) Thanks for your reply! |
|
@fzyzcjy Did you have a chance to look into testing this or applying for the test exception? |
|
@goderbauer Ah I forgot it completely. Here is the exemption request a few seconds ago: https://discordapp.com/channels/608014603317936148/608018585025118217/1029170238190784704 |
|
test-exempt: code refactor with no semantic change |
… to improve performance and style (flutter/flutter#111849)
… to improve performance and style (flutter/flutter#111849)
Hi, hope to have a quick view whether this PR is acceptable or not? If yes I will add an issue and maybe ask for test-exempt.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.