Skip to content

Change type in ImplicitlyAnimatedWidget to remove type cast to improve performance and style#111849

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
fzyzcjy:patch-16
Oct 13, 2022
Merged

Change type in ImplicitlyAnimatedWidget to remove type cast to improve performance and style#111849
auto-submit[bot] merged 1 commit intoflutter:masterfrom
fzyzcjy:patch-16

Conversation

@fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Sep 19, 2022

Hi, hope to have a quick view whether this PR is acceptable or not? If yes I will add an issue and maybe ask for test-exempt.


Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs framework flutter/packages/flutter repository. See also f: labels. labels Sep 19, 2022
@fzyzcjy fzyzcjy marked this pull request as ready for review September 19, 2022 12:57
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fzyzcjy fzyzcjy changed the title Change type to remove type cast to improve performance and style Change type in ImplicitlyAnimatedWidget to remove type cast to improve performance and style Sep 19, 2022
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

@fzyzcjy I believe this just needs a test (or probably just a test exemption) to land.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Sep 27, 2022

@goderbauer I agree. Not sure how it can be tested though, so I will ask a test-exempt.

I will do it maybe a few days later since I am working on #101227 (and on discord), and do not want to have too many things on discord in one day :)

Thanks for your reply!

@goderbauer
Copy link
Member

@fzyzcjy Did you have a chance to look into testing this or applying for the test exception?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 10, 2022

@goderbauer Ah I forgot it completely. Here is the exemption request a few seconds ago: https://discordapp.com/channels/608014603317936148/608018585025118217/1029170238190784704

@Hixie
Copy link
Contributor

Hixie commented Oct 11, 2022

test-exempt: code refactor with no semantic change

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2022
@auto-submit auto-submit bot merged commit 50b1960 into flutter:master Oct 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: animation Animation APIs autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants