Fixed an issue with FilterChips changing size when selected.#111916
Merged
darrenaustin merged 1 commit intoflutter:masterfrom Sep 19, 2022
darrenaustin:m3_chip_size_issue
Merged
Fixed an issue with FilterChips changing size when selected.#111916darrenaustin merged 1 commit intoflutter:masterfrom darrenaustin:m3_chip_size_issue
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:m3_chip_size_issue
Conversation
This was referenced Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 20, 2022
…due to border size. (flutter/flutter#111916)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 20, 2022
…due to border size. (flutter/flutter#111916)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #111038, the size of the
FilterChipwould change if it was selected or not. This made it hard to line up these chips in a row as they would bounce around as selection changed.This was due to the fact that we were not adding a border for the selected case. This meant that the size would be off by the size of the border. To fix this we are just using a transparent border of the same size to ensure it will be the same size as the unselected which do have a border.
Fixes: #111038
Pre-launch Checklist
///).