[macOS] Test hang after calling runApp twice and resizing.#112008
Closed
a-wallen wants to merge 6 commits intoflutter:masterfrom
Closed
[macOS] Test hang after calling runApp twice and resizing.#112008a-wallen wants to merge 6 commits intoflutter:masterfrom
a-wallen wants to merge 6 commits intoflutter:masterfrom
Conversation
127c157 to
bdc3e23
Compare
8 tasks
bdc3e23 to
df697e0
Compare
8 tasks
df697e0 to
e5f35a2
Compare
added 6 commits
September 23, 2022 09:27
(Lazy) rename project
e5f35a2 to
ef58921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of a fix for #92673. In short, calling run app twice, the second with no content, and then resizing the window caused apps to hang. The initial fix should be landed here: flutter/engine#35409. The test for it is easier when the framework is available which is why this change is being landed in the
flutter/flutterrepo.2 part fix to #92673
Pre-launch Checklist
///).