Skip to content

[Android] Fix spell_check integration test flakiness#112109

Merged
auto-submit[bot] merged 7 commits intoflutter:masterfrom
camsim99:sc_flake
Oct 4, 2022
Merged

[Android] Fix spell_check integration test flakiness#112109
auto-submit[bot] merged 7 commits intoflutter:masterfrom
camsim99:sc_flake

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Sep 21, 2022 •
edited
Loading

Fixes #112081, fixes #111569.

Specifies duration to delay pumping a frame in test to allow for spell check results to be received before the test tries to renders the misspelled text that should be marked as such.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 21, 2022
@camsim99 camsim99 requested a review from justinmc September 21, 2022 22:47
@camsim99 camsim99 requested a review from keyonghan as a code owner September 30, 2022 21:29
@camsim99 camsim99 changed the title Specify pump duration for spell_check integration test [Android] Fix spell_check integration test flakiness Sep 30, 2022
@jmagman
Copy link
Member

jmagman commented Oct 3, 2022

@camsim99 any progress getting this merged? The test is very flaky. Looks like you have an analyzer issues.

justinmc
justinmc approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 with a docs nit.

@camsim99 is on vacation, but I will accept my docs suggestion and then try to merge this. I'm hoping this will resolve the flakiness if everything works as expected. If not I can open a PR to skip this test until @camsim99 is back.

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2022
@auto-submit auto-submit bot merged commit b94b584 into flutter:master Oct 4, 2022
@justinmc justinmc mentioned this pull request Oct 4, 2022
Closed
This was referenced Oct 5, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
b94b584 [Android] Fix spell_check integration test flakiness (flutter…
95d19a1 
…/flutter#112109)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
b94b584 [Android] Fix spell_check integration test flakiness (flutter…
f6a6081 
…/flutter#112109)
This was referenced Oct 5, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
b94b584 [Android] Fix spell_check integration test flakiness (flutter…
7797991 
…/flutter#112109)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2022
@engine-flutter-autoroll
b94b584 [Android] Fix spell_check integration test flakiness (flutter…
30a8aec 
…/flutter#112109)
@camsim99 camsim99 mentioned this pull request Oct 17, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux_android spell_check_test is 11.22% flaky Linux_android spell_check_test is 5.10% flaky

3 participants

@camsim99 @jmagman @justinmc