Revert DraggableScrollableSheet controller changes#112293
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Sep 23, 2022
Merged
Revert DraggableScrollableSheet controller changes#112293auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
added 2 commits
September 23, 2022 18:33
)" This reverts commit 0322b57.
flutter-dashboard
bot
added
f: scrolling
Contributor
|
Weird. Do you have an example of the failure, so I can ensure it's fixed when relanding? |
CaseyHillers
added
the
autosubmit
Contributor
Author
@chunhtai or @HansMuller will be able to reproduce a more complete example, but there was an instance of an svg icon being squished. |
This was referenced Sep 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 24, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 24, 2022
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This broke some use cases causing several assets to get squashed. An example was a triangle icon becoming a flat line.