Wait for non-empty layout in platform view placeholder#112402
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Oct 5, 2022
Merged
Conversation
In `PlatformViewLink`, trigger creation of the platform view on the first non-empty layout, rather than the first layout, since using an empty size triggers an assertion in the platform view creation. Fixes flutter#111255
flutter-dashboard
bot
added
the
framework
stuartmorgan-g
added
the
autosubmit
This was referenced Oct 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2022
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter
that referenced
this pull request
Oct 6, 2022
XilaiZhang
pushed a commit
that referenced
this pull request
Oct 25, 2022
…3040) Co-authored-by: Kevin Chisholm <[email protected]> Co-authored-by: godofredoc <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
PlatformViewLink, trigger creation of the platform view on the first non-empty layout, rather than the first layout, since using an empty size triggers an assertion in the platform view creation.Fixes #111255
Pre-launch Checklist
///).