Skip to content

Revert "Marks Mac_arm64 tool_host_cross_arch_tests to be unflaky"#112579

Merged
jmagman merged 1 commit intomasterfrom
revert-112558-APWtk1q6s9
Sep 28, 2022
Merged

Revert "Marks Mac_arm64 tool_host_cross_arch_tests to be unflaky"#112579
jmagman merged 1 commit intomasterfrom
revert-112558-APWtk1q6s9

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 28, 2022

Reverts #112558

This is passing in staging but is being hit by #112130 in prod.

@keyonghan how do we get the bot to not mark this as unflaky? It was never flaky, but in "bringup".

@jmagman jmagman self-assigned this Sep 28, 2022
@jmagman jmagman requested a review from keyonghan as a code owner September 28, 2022 18:07
@jmagman jmagman merged commit 2f0f49f into master Sep 28, 2022
@jmagman jmagman deleted the revert-112558-APWtk1q6s9 branch September 28, 2022 18:09
@keyonghan
Copy link
Contributor

keyonghan commented Sep 28, 2022

Reverts #112558

This is passing in staging but is being hit by #112130 in prod.

@keyonghan how do we get the bot to not mark this as unflaky? It was never flaky, but in "bringup".

Yeah, a property ignore_flakiness: "true" will do the trick. Like: https://github.com/flutter/flutter/blob/master/.ci.yaml#L2271

BTW: for revert, you can add the revert label, the bot will land the PR right away ignoring tree status and CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants