Only run generateLockfiles when lockfiles are missing#112723
Closed
GaryQian wants to merge 2 commits intoflutter:masterfrom
Closed
Only run generateLockfiles when lockfiles are missing#112723GaryQian wants to merge 2 commits intoflutter:masterfrom
GaryQian wants to merge 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Contributor
|
Closing as there is no one to take this over. |
9 tasks
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
…guration time (#162220)  This PR attempts to fix #110559 This PR supersedes #147837 Original attempt at fixing this by @GaryQian: #112723 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #110559, gradle dependency locking can take a very long time to complete. Since generating locks is not something that has to be done on every run. We should: