Skip to content

Minor change type nullability#112778

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
fzyzcjy:patch-21
Oct 10, 2022
Merged

Minor change type nullability#112778
auto-submit[bot] merged 2 commits intoflutter:masterfrom
fzyzcjy:patch-21

Conversation

@fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Oct 3, 2022

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Oct 3, 2022
fzyzcjy added a commit to fzyzcjy/flutter_smooth that referenced this pull request Oct 3, 2022
@goderbauer goderbauer self-requested a review October 7, 2022 21:28
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

Any reason this is still marked as Draft?

This will need a testing exception.

@fzyzcjy fzyzcjy marked this pull request as ready for review October 10, 2022 23:08
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 10, 2022

Any reason this is still marked as Draft?

No, I just forgot it :)

This will need a testing exception.

I think so, thanks

@Hixie
Copy link
Contributor

Hixie commented Oct 10, 2022

test-exempt: API refactor

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2022
@auto-submit auto-submit bot merged commit 21fab6f into flutter:master Oct 10, 2022
jmagman added a commit that referenced this pull request Oct 11, 2022
jmagman added a commit that referenced this pull request Oct 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 11, 2022
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Oct 13, 2022
CaseyHillers pushed a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants