Skip to content

[stable hotfix] update engine version#112868

Merged
XilaiZhang merged 1 commit intoflutter:flutter-3.2-candidate.5from
XilaiZhang:flutter-3.2-candidate.5
Oct 4, 2022
Merged

[stable hotfix] update engine version#112868
XilaiZhang merged 1 commit intoflutter:flutter-3.2-candidate.5from
XilaiZhang:flutter-3.2-candidate.5

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Oct 4, 2022

includes the two engine cherrypicks. engine binaries have been code signed.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Oct 4, 2022
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Acking the flutter plugins failure as it's an analyzer issue. This target shouldn't be run on releases

@CaseyHillers
Copy link
Contributor

https://github.com/flutter/flutter/blob/master/.ci.yaml already has it updated. Looks like it hasn't made it into the release

@XilaiZhang
Copy link
Contributor Author

thanks for reviewing Casey! there are 2 tests still queued, will wait a bit for them to run

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2022
@XilaiZhang
Copy link
Contributor Author

like Casey and sir Godofredo pointed out, the 1 failed test and 2 queued tests have been removed from ci.yaml on master. will skip them.

@XilaiZhang XilaiZhang merged commit 914bd15 into flutter:flutter-3.2-candidate.5 Oct 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 5, 2022
@XilaiZhang XilaiZhang deleted the flutter-3.2-candidate.5 branch December 15, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants