Return void from project migrate()#112897
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Oct 5, 2022
Merged
Conversation
jmagman
added
the
tool
jmagman
commented
Oct 5, 2022
| final File gitignore = _project.parent.directory.childFile('.gitignore'); | ||
|
|
||
| if (!removeFile(registrant)) { | ||
| return false; |
Member
Author
There was a problem hiding this comment.
This was the only migration that ever returned false. We already have the error io file deletion fallbacks, and I'd argue failing to delete this file shouldn't be catastrophic and fail the web build.
This was referenced Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate()was set up to return whether the project migration succeeded, and fail the build if the migration failed. But all the migrations always returnedtrue(except in one file deletion case that shouldn't have failed the build).Change signature to
void migration()Follow up from #112828 (comment)