Add overlay MaterialStateProperty property to Slider#112922
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Oct 6, 2022
Merged
Add overlay MaterialStateProperty property to Slider#112922auto-submit[bot] merged 2 commits intoflutter:masterfrom
overlay MaterialStateProperty property to Slider#112922auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: material design
HansMuller
reviewed
Oct 5, 2022
Contributor
|
Lots of test failures that didn't appear to be related to this PR. I've tried restarting them. You may need to resync with master |
TahaTesser
force-pushed
the
slider_overlay
branch
from
54d0710 to
e9b731b
Compare
HansMuller
approved these changes
Oct 6, 2022
TahaTesser
added
the
autosubmit
This was referenced Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 6, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #112864
This PR does the following:
overlayMaterialStateProperty property.SliderTheme.overlayand newSlider.overlayproperty (movestatesabove sosliderTheme.copyWithcan access the states).Slider uses the right theme colors for the right componentstheme test fromslider_test.darttoslider_theme_test.dartThis is preliminary work for #111451
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.