Upgrade targetSdkVersion and compileSdkVersion to 33#112936
Upgrade targetSdkVersion and compileSdkVersion to 33#112936auto-submit[bot] merged 6 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
I think we should make an end-to-end test where we flutter create a project, add some Android call that's from the latest SDK we support in that project's source, and then compile it; then we can update what that call is whenever we are bumping the version, to validate that this is actually working as expected.
|
Yeah, that sounds good, I'll make a test like that! |
|
@stuartmorgan Added the test. |
GaryQian
added
the
autosubmit
2 participants
Upgrade targetSdkVersion and compileSdkVersion to 33
Addresses #103356
Issues with app startup on emulators have been resolved as of 3.3.0