When updating packages, do not delete the simulated SDK directory until all pub invocations have finished#112975
Conversation
…il all pub invocations have finished Fixes flutter#112904
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@christopherfujino PTAL to unblock the Dart -> Engine roller. |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, thanks so much for finding this!
jason-simmons
added
the
autosubmit
…tory until all pub invocations have finished (flutter/flutter#112975)
…tory until all pub invocations have finished (flutter/flutter#112975)
…tory until all pub invocations have finished (flutter/flutter#112975)
…tory until all pub invocations have finished (flutter/flutter#112975)
3 participants
Fixes #112904