CP: Wait for non-empty layout in platform view placeholder#113040
Conversation
flutter-dashboard
bot
added
the
framework
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Seems low-risk and worthy of cherry picking from my understanding.
@stuartmorgan FYI this needs a merge. I think the test failure will also be fixed by the merge.
|
Looks like the branch is not in a good state in general. For instance, the customer test is trying to run analysis of a package that's using an option that doesn't exist in the analyzer on stable, it looks like. |
That is correct, customer_tests have never worked correctly for release branches. |
|
What's the path for landing this if tests are known not to pass? |
|
|
umm I checked the target history and it looks like linux plugins has always been failing, I went ahead and squash and merged |
5 participants
Cherry-picks #112402 to stable.