[flutter_tool] Don't download CanvasKit if it's already in flutter_web_sdk#113072
Merged
harryterkelsen merged 4 commits intoflutter:masterfrom Oct 7, 2022
Merged
Conversation
harryterkelsen
added
tool
Contributor
|
Going forward, will we still need to support downloading from the canvaskit URL, or is the idea to only use the prebuilt? |
Contributor
Author
|
The plan is to only use the prebuilt version |
Contributor
|
It sounds like this is for a soft transition we need to make then? Could you link a bug in the code here with a note that it can all be deleted once the work is completed? |
Contributor
Author
|
Done. PTAL |
mdebbar
approved these changes
Oct 7, 2022
This was referenced Oct 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't download CanvasKit from CIPD if it's already included in the
flutter_web_sdkengine artifacts.We are building CanvasKit locally in the Flutter engine now, and soon will be bundling it with
flutter_web_sdk. This change causes flutter_tool to use the built version rather than the one from CIPD when the built version is available.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.