Skip to content

Report coverage to codecov rather than coveralls.#113084

Merged
auto-submit[bot] merged 4 commits intomasterfrom
godofredoc-patch-2
Oct 7, 2022
Merged

Report coverage to codecov rather than coveralls.#113084
auto-submit[bot] merged 4 commits intomasterfrom
godofredoc-patch-2

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Oct 7, 2022 •
edited
Loading

Coveralls was not processing the files correctly and was always showing a 0% progress.

Bug: #81803

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc marked this pull request as draft October 7, 2022 04:32
@coveralls
Copy link

coveralls commented Oct 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3202272178

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 3201957429: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #113084 (9136489) into master (721ce7a) will increase coverage by 20.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           master   #113084       +/-   ##
============================================
+ Coverage   70.68%    91.44%   +20.75%     
============================================
  Files         204       522      +318     
  Lines       22636     94295    +71659     
============================================
+ Hits        16000     86225    +70225     
- Misses       6636      8070     +1434
Flag Coverage Δ
flutter_tool ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/flutter_tools/lib/src/commands/build_bundle.dart
packages/flutter_tools/lib/src/devfs.dart
...kages/flutter_tools/lib/src/test/test_wrapper.dart
.../flutter_tools/lib/src/android/android_studio.dart
packages/flutter_tools/lib/src/artifacts.dart
...utter_tools/lib/src/commands/shell_completion.dart
...flutter_tools/lib/src/test/coverage_collector.dart
...kages/flutter_tools/lib/src/commands/generate.dart
...tools/lib/src/base/error_handling_file_system.dart
...ckages/flutter_tools/lib/src/base/file_system.dart
... and 716 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca314a...9136489. Read the comment docs.

ricardoamador
ricardoamador approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc marked this pull request as ready for review October 7, 2022 18:48
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 7, 2022
@godofredoc godofredoc changed the title validate file location and content. Report coverage to codecov rather than coveralls. Oct 7, 2022
@auto-submit auto-submit bot merged commit bd4376c into master Oct 7, 2022
@auto-submit auto-submit bot deleted the godofredoc-patch-2 branch October 7, 2022 19:50
This was referenced Oct 8, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2022
@engine-flutter-autoroll
bd4376c Report coverage to codecov rather than coveralls. (flutter/fl…
4d7ed49 
…utter#113084)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 8, 2022
@engine-flutter-autoroll
bd4376c Report coverage to codecov rather than coveralls. (flutter/fl…
a720abb 
…utter#113084)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ricardoamador ricardoamador ricardoamador approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @coveralls @codecov-commenter @ricardoamador