Skip to content

Fix TabBar with padding is not centered#113091

Merged
HansMuller merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_tabbar_with_padding_not_centered
Oct 7, 2022
Merged

Fix TabBar with padding is not centered#113091
HansMuller merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_tabbar_with_padding_not_centered

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Oct 7, 2022

Description

This PR updates scrollable TabBar centering logic to take into account TabBar.padding.

Related Issue

Fixes #112776

Tests

Adds 2 tests.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 7, 2022
@bleroux bleroux requested a review from HansMuller October 7, 2022 20:08
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! LGTM

@HansMuller HansMuller merged commit 91b5079 into flutter:master Oct 7, 2022
@bleroux bleroux deleted the fix_tabbar_with_padding_not_centered branch October 7, 2022 20:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TabBar with padding not functioning as expected

2 participants