Skip to content

Add coverage badge.#113123

Merged
godofredoc merged 1 commit intomasterfrom
godofredoc-patch-1
Oct 7, 2022
Merged

Add coverage badge.#113123
godofredoc merged 1 commit intomasterfrom
godofredoc-patch-1

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Oct 7, 2022

We are finally generating coverage reports on post submit for the flutter repository. This is adding the badge to the README file of the repository.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add coverage badge.
2e4f1d8 
We are finally generating coverage reports on post submit for the flutter repository.
This is adding the badge to the README file of the repository.
christopherfujino
christopherfujino reviewed Oct 7, 2022
View reviewed changes
README.md
[![Build Status - Cirrus][]][Build status]
[![Discord badge][]][Discord instructions]
[![Twitter handle][]][Twitter badge]
[![codecov](https://codecov.io/gh/flutter/flutter/branch/master/graph/badge.svg?token=11yDrJU2M2)](https://codecov.io/gh/flutter/flutter)
Copy link
Contributor

@christopherfujino christopherfujino Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like this is only coverage for Flutter tools. Do we still want to show this badge? And if so, we should probably clarify.

Copy link
Contributor

@christopherfujino christopherfujino Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.codecov.io/gh/flutter/flutter/tree/master/packages

Copy link
Contributor

@christopherfujino christopherfujino Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we shouldn't land this, we haven't uploaded these reports in years

Copy link
Contributor

@christopherfujino christopherfujino Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.codecov.io/gh/flutter/flutter/commits

Copy link
Contributor Author

@godofredoc godofredoc Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed that yesterday: https://github.com/flutter/flutter/actions/workflows/coverage.yml we will be generating per commit reports starting in a few mins from now.

Copy link
Contributor

@christopherfujino christopherfujino Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I see this updated now, LGTM!

christopherfujino
christopherfujino suggested changes Oct 7, 2022
View reviewed changes
README.md
[![Build Status - Cirrus][]][Build status]
[![Discord badge][]][Discord instructions]
[![Twitter handle][]][Twitter badge]
[![codecov](https://codecov.io/gh/flutter/flutter/branch/master/graph/badge.svg?token=11yDrJU2M2)](https://codecov.io/gh/flutter/flutter)
Copy link
Contributor

@christopherfujino christopherfujino Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we shouldn't land this, we haven't uploaded these reports in years

christopherfujino
christopherfujino approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2022-10-07 15-14-05

LGTM

@godofredoc godofredoc merged commit f0c3e57 into master Oct 7, 2022
@godofredoc godofredoc deleted the godofredoc-patch-1 branch October 7, 2022 23:42
This was referenced Oct 8, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2022
@engine-flutter-autoroll
f0c3e57 Add coverage badge. (flutter/flutter#113123)
46bbd8d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 8, 2022
@engine-flutter-autoroll
f0c3e57 Add coverage badge. (flutter/flutter#113123)
7cb90db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @christopherfujino