pushnamed can handle Object as type#113242
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Oct 13, 2022
Merged
Conversation
flutter-dashboard
bot
added
f: routes
chunhtai
commented
Oct 10, 2022
| expect(find.text('/second'), findsOneWidget); | ||
| }); | ||
|
|
||
| testWidgets('Pending gestures are rejected', (WidgetTester tester) async { |
Contributor
Author
There was a problem hiding this comment.
only indent change.
chunhtai
added
the
autosubmit
This was referenced Oct 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #57186, but this only allows T to be set as Object. If we want to support int or other type, it requires a big workaround or wait for dart to allow cast type for custom class.
This pr will allow internal customer to migrate to sound null safety
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.