Revert "Minor change type nullability"#113246
Conversation
This reverts commit 21fab6f.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
f: scrolling
|
cc @fzyzcjy |
|
So, shall I update that sample which breaks tree and PR again, or shall I just leave it there (the imperfect nullability)? 👀 Btw is there any methods I can know it will break the tree before merging - I do not intend to do so :( |
You can check if https://github.com/flutter/gallery |
|
@jmagman Thanks! |
|
FYI, upstream PR created: letsar/flutter_staggered_grid_view#274 |
@fzyzcjy I am not an expert in this, but I believe that this test failure makes this a breaking change? Can you make sure to coordinate in Discord with #hackers-framework about what to do instead of just changing |
You are right, I forgot that and will do that soon. |
This reverts commit 21fab6f.
…#113399) This reverts commit 21fab6f. Co-authored-by: Jenn Magder <[email protected]>
3 participants
Reverts #112778
This caused gallery to stop building: #113245