Skip to content

Fix Android Studio version string nullablity, fake AndroidStudio in test#113295

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jmagman:analytics-fake
Oct 12, 2022
Merged

Fix Android Studio version string nullablity, fake AndroidStudio in test#113295
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jmagman:analytics-fake

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 11, 2022

Fixes #113294

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 11, 2022
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 11, 2022
Jasguerrero
Jasguerrero approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2022
@auto-submit auto-submit bot merged commit 2f03dda into flutter:master Oct 12, 2022
@jmagman jmagman deleted the analytics-fake branch October 12, 2022 18:48
This was referenced Oct 13, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2022
@engine-flutter-autoroll
2f03dda Fix Android Studio version string nullablity, fake AndroidStu…
19e6517 
…dio in test (flutter/flutter#113295)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 13, 2022
@engine-flutter-autoroll
2f03dda Fix Android Studio version string nullablity, fake AndroidStu…
0d54bcd 
…dio in test (flutter/flutter#113295)
@andrewkolos andrewkolos mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tool test analytics_test fails locally when Android Studio is installed

2 participants

@jmagman @Jasguerrero