Write crash report in temp directory if writing to CWD failed.#113316
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Oct 12, 2022
Merged
Write crash report in temp directory if writing to CWD failed.#113316auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
Based on the code, this was the original intention but is now broken because `ErrorHandlingFileSystem` throws a `ToolExit`, but the crash handler is only catching `FileSystemException`. Wrap the filesystem calls with `ErrorHandlingFileSystem.noExitOnFailure` so that it throws the right exception, and update `ErrorHandlingFileSystem` to throw `FileSystemException` instead of the generic `Exception`, to match the behavior described in the comments.
flutter-dashboard
bot
added
the
tool
christopherfujino
approved these changes
Oct 12, 2022
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Lgtm, good catch!
chingjun
added
the
autosubmit
This was referenced Oct 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the code, this was the original intention but is now broken because
ErrorHandlingFileSystemthrows aToolExit, but the crash handler is only catchingFileSystemException.Wrap the filesystem calls with
ErrorHandlingFileSystem.noExitOnFailureso that it throws the right exception, and updateErrorHandlingFileSystemto throwFileSystemExceptioninstead of the genericException, to match the behavior described in the comments.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.