Skip to content

Enable impeller flags for iOS simulator#113350

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jmagman:impeller-simulator
Oct 12, 2022
Merged

Enable impeller flags for iOS simulator#113350
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jmagman:impeller-simulator

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 12, 2022 

[  +12 ms] executing: xcrun simctl launch AE176D28-EC86-4472-B48D-3DC32202B267 io.flutter.examples.gallery --enable-dart-profiling --enable-checked-mode --verify-entry-points --enable-impeller --observatory-port=0
[ +397 ms] io.flutter.examples.gallery: 76484
[        ] Waiting for observatory port to be available...
[+1183 ms] [VERBOSE-2:ios_context_metal_impeller.mm(22)] Using the Impeller rendering backend.

Fixes #113349

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added the e: impeller Impeller rendering backend issues and features requests label Oct 12, 2022
@jmagman jmagman self-assigned this Oct 12, 2022
@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 12, 2022
dnfield
dnfield approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso fyi

@dnfield
Copy link
Contributor

dnfield commented Oct 12, 2022

Thanks for the quick fix!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2022
@auto-submit auto-submit bot merged commit 61ac000 into flutter:master Oct 12, 2022
@jmagman jmagman deleted the impeller-simulator branch October 12, 2022 22:34
This was referenced Oct 13, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2022
@engine-flutter-autoroll
61ac000 Enable impeller flags for iOS simulator (flutter/flutter#113350)
c3587cc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 13, 2022
@engine-flutter-autoroll
61ac000 Enable impeller flags for iOS simulator (flutter/flutter#113350)
f9a3933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller Impeller rendering backend issues and features requests platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter run --enable-impeller broken for simulators

2 participants

@jmagman @dnfield