Skip to content

Added statesController to the button icon constructors.#113419

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
darrenaustin:button_states_controller
Oct 17, 2022
Merged

Added statesController to the button icon constructors.#113419
auto-submit[bot] merged 2 commits intoflutter:masterfrom
darrenaustin:button_states_controller

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Oct 14, 2022 •
edited
Loading

#103167 added statesController as an argument to the *Button constructors. However, the *Button.icon constructors should also provide this parameter. This PR adds statesController to all the button constructors that were missed in the original PR.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 14, 2022
gspencergoog
gspencergoog approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@darrenaustin darrenaustin added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2022
@auto-submit auto-submit bot merged commit 789d668 into flutter:master Oct 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
789d668 Added statesController to the button icon constructors. (flut…
abd64b7 
…ter/flutter#113419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 17, 2022
@engine-flutter-autoroll
789d668 Added statesController to the button icon constructors. (flut…
f35ac12 
…ter/flutter#113419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 19, 2022
@engine-flutter-autoroll
789d668 Added statesController to the button icon constructors. (flut…
ac1074b 
…ter/flutter#113419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darrenaustin @gspencergoog