Terminate simulator app on "q"#113581
Conversation
jmagman
added
platform-ios
| ); | ||
| }); | ||
|
|
||
| testWithoutContext('.stopApp() handles exceptions', () async { |
There was a problem hiding this comment.
is there a way to test that the app is actually terminated?
There was a problem hiding this comment.
Do you mean in an integration test? Let me see if I can get something working...
There was a problem hiding this comment.
Added a check to the hot reload tests.
| tags: > | ||
| ["devicelab", "android", "linux"] | ||
| task_name: hot_mode_dev_cycle_linux__benchmark | ||
| runIf: |
There was a problem hiding this comment.
I'm not going to check these .ci.yaml changes in, I just want to see if the desktop tests pass in presubmit.
| return result; | ||
| } | ||
|
|
||
| Future<void> _checkAppRunning(bool shouldBeRunning) async { |
There was a problem hiding this comment.
Something tells me this will be a flake factory... Will delete if that starts happening.
flutter-dashboard
bot
added
the
c: contributor-productivity
TESTOWNERS
Outdated
| /dev/devicelab/bin/tasks/fullscreen_textfield_perf_impeller_ios__e2e_summary.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/fullscreen_textfield_perf_ios__e2e_summary.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/hello_world_ios__compile.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios_simulator.dart @zanderso @flutter/tool |
There was a problem hiding this comment.
@zanderso added this new test to validate hot reload on iOS simulators. I matched the owner to the other hot_mode_dev_cycle benchmarks but I'm happy to own if you prefer.
There was a problem hiding this comment.
If/when the new test flakes, I'd just be routing it to you anyway, so cutting out the middleman and putting yourself as the owner seems like it would make sense.
There was a problem hiding this comment.
If any of the hot reload tests start flaking on checking the running processes they will be routed to me, but any actual issues with the hot reloading will be routed to you 🙂
Fortunately we know where to find each other.
|
Still LGTM |
jmagman
added
the
autosubmit
|
Partial revert at #114083 |
…114098) Co-authored-by: Jenn Magder <[email protected]>
4 participants
Add a new non-benchmark
hot_mode_dev_cycle_ios_simulatortest to validate hot reload works on an iOS simulator.Fixes #113580
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.