fixes for incoming linter by pq · Pull Request #113794 · flutter/flutter

pq · 2022-10-20T20:37:33Z

The new linter has some fixes that introduce a few new diagnostics that need addressing.

See: https://dart-review.googlesource.com/c/sdk/+/264961

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2022-10-20T20:56:02Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

pq · 2022-10-31T17:52:03Z

Not sure what's up w/ the ci.yaml validation failure but seems unrelated. I wasn't able to trigger a re-run but @goderbauer, maybe you can?

packages/flutter/lib/src/material/menu_anchor.dart

packages/flutter_test/lib/src/test_compat.dart

goderbauer · 2022-10-31T18:01:49Z

@pq I triggered a re-run, but you likely need to rebase this PR to the latest master to make it pass...

goderbauer

LGTM

goderbauer · 2022-10-31T18:10:54Z

Looks like you'll need to rebase to the latest master to make the ci.yaml validation happy...

pq · 2022-10-31T18:14:41Z

Ah, thanks. Rebase and all seems good.

Much appreciated!

packages/flutter/lib/src/widgets/layout_builder.dart

goderbauer

LGTM

packages/flutter/lib/src/widgets/layout_builder.dart

goderbauer

LGTM

auto-submit · 2022-11-02T18:55:48Z

auto label is removed for flutter/flutter, pr: 113794, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)

Downstream fixes: * flutter/flutter#113794 * flutter/plugins#6669 * flutter/engine#37321 * dart-archive/linter#3775 * dart-archive/linter#3776 * cl/482614222 * cl/482654980 * cl/482744309 * cl/485129394 * cl/485139323 * ... Upstream: * #50263 Change-Id: I259cb0c28464b1e513d9a1931b7c680a2a04a0a4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264961 Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>

* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)

* fixes for incomming linter * + todo * todo format fix * justify ignore * --

* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615) * a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621) * 33b81ed fixes for incoming linter (flutter/flutter#113794) * 0186b14 Fix the path where footer is written. (flutter/flutter#114469) * 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640) * 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643) * 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634) * 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647) * 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648) * 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646) * 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651) * fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667) * 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668) * 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670) * 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674) * 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678) * 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)

fixes for incomming linter

615bdd1

flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 20, 2022

pq marked this pull request as draft October 20, 2022 20:54

pq changed the title ~~fixes for incoming linter~~ 🔴 fixes for incoming linter Oct 20, 2022

+ todo

ec5a17c

pq marked this pull request as ready for review October 31, 2022 17:45

pq requested a review from goderbauer October 31, 2022 17:45

goderbauer reviewed Oct 31, 2022

View reviewed changes

packages/flutter/lib/src/material/menu_anchor.dart Outdated Show resolved Hide resolved

packages/flutter_test/lib/src/test_compat.dart Outdated Show resolved Hide resolved

pq added 2 commits October 31, 2022 11:03

todo format fix

10839f8

justify ignore

6050e42

goderbauer approved these changes Oct 31, 2022

View reviewed changes

Merge branch 'master' into linter_129_fixes

33da11b

pq added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2022

pq changed the title ~~🔴 fixes for incoming linter~~ fixes for incoming linter Oct 31, 2022

goderbauer requested changes Oct 31, 2022

View reviewed changes

packages/flutter/lib/src/widgets/layout_builder.dart Show resolved Hide resolved

goderbauer removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2022

goderbauer approved these changes Oct 31, 2022

View reviewed changes

packages/flutter/lib/src/widgets/layout_builder.dart Show resolved Hide resolved

--

d3f6f1c

goderbauer approved these changes Oct 31, 2022

View reviewed changes

pq added 2 commits November 1, 2022 09:23

Merge branch 'master' into linter_129_fixes

141cc9f

Merge branch 'master' into linter_129_fixes

e0ee02a

pq added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2022

flutter-dashboard bot added the f: scrolling Viewports, list views, slivers, etc. label Nov 1, 2022

Merge branch 'master' into linter_129_fixes

afea319

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2022

pq added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2022

pq merged commit 33b81ed into flutter:master Nov 3, 2022

pq deleted the linter_129_fixes branch November 3, 2022 17:57

This was referenced Nov 4, 2022

Roll Flutter from e6300da2c39f to 55e8cd178621 (17 revisions) flutter/packages#2780

Merged

Roll Flutter from e6300da2c39f to 55e8cd178621 (17 revisions) flutter/plugins#6670

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2022

33b81ed fixes for incoming linter (flutter/flutter#113794)

67c6604

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 4, 2022

33b81ed fixes for incoming linter (flutter/flutter#113794)

d1f9d46

pq mentioned this pull request Nov 9, 2022

[cleanup] remove unnecessary brace in string interpolation #115032

Merged

8 tasks

shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022

fixes for incoming linter (flutter#113794)

f35dcca

* fixes for incomming linter * + todo * todo format fix * justify ignore * --

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes for incoming linter#113794

fixes for incoming linter#113794
pq merged 9 commits intoflutter:masterfrom
pq:linter_129_fixes

pq commented Oct 20, 2022 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Oct 20, 2022

Uh oh!

pq commented Oct 31, 2022

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Oct 31, 2022

Uh oh!

goderbauer left a comment

Uh oh!

goderbauer commented Oct 31, 2022

Uh oh!

pq commented Oct 31, 2022

Uh oh!

Uh oh!

goderbauer left a comment

Uh oh!

Uh oh!

goderbauer left a comment

Uh oh!

auto-submit bot commented Nov 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pq commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Oct 20, 2022

Uh oh!

pq commented Oct 31, 2022

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Oct 31, 2022

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Oct 31, 2022

Uh oh!

pq commented Oct 31, 2022

Uh oh!

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pq commented Oct 20, 2022 •

edited

Loading