chore: enable Flutter Android workflow on aarch64 by TheOneWithTheBraid · Pull Request #113829 · flutter/flutter

TheOneWithTheBraid · 2022-10-21T11:43:32Z

removes invalid arch check on Android workflow in order to enable Android development on any device supported

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino · 2022-10-27T20:45:24Z

Tests are failing, but it seems like a straightforward fix. Otherwise this looks good to me. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8799695687766054785/+/u/run_test.dart_for_tool_tests_shard_and_subshard_general/test_stdout

christopherfujino

LGTM

christopherfujino · 2022-10-27T20:46:18Z

@eliasyishak

eliasyishak

LGTM, just need to fix that test case

christopherfujino · 2022-11-03T20:35:15Z

@TheOneWithTheBraid friendly ping about your failing tests

TheOneWithTheBraid · 2022-11-04T04:38:46Z

Thanks, @christopherfujino. I unfortunately don't know really how the particular failing tests are affected by these changes. Could you give me a clue?

TheOneWithTheBraid · 2022-11-04T06:41:15Z

E.g. in regard of https://github.com/flutter/flutter/pull/113829/checks?check_run_id=9289286117, I cannot reproduce the failures locally. Is there anything to know about in order to bootstrap a CI-like test environment?

 flutter --no-version-check test test/general.shard/daemon_test.dart
00:01 +25: All tests passed!

Detailed JSON logs

 flutter --no-version-check test -r json test/general.shard/daemon_test.dart
Running "flutter pub get" in flutter_tools...                       5.3s
{"protocolVersion":"0.1.1","runnerVersion":"1.21.7","pid":10682,"type":"start","time":0}
{"suite":{"id":0,"platform":"vm","path":"/home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"suite","time":0}
{"test":{"id":1,"name":"loading /home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":1}
{"count":1,"time":5,"type":"allSuites"}
{"testID":1,"result":"success","skipped":false,"hidden":true,"type":"testDone","time":10934}
{"group":{"id":2,"suiteID":0,"parentID":null,"name":"","metadata":{"skip":false,"skipReason":null},"testCount":25,"line":null,"column":null,"url":null},"type":"group","time":10938}
{"group":{"id":3,"suiteID":0,"parentID":2,"name":"DaemonConnection receiving end","metadata":{"skip":false,"skipReason":null},"testCount":2,"line":52,"column":3,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"group","time":10938}
{"test":{"id":4,"name":"DaemonConnection receiving end redirects input to incoming commands","suiteID":0,"groupIDs":[2,3],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":53,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":10938}
{"testID":4,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":10968}
{"test":{"id":5,"name":"DaemonConnection receiving end listenToEvent can receive the right events","suiteID":0,"groupIDs":[2,3],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":63,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":10970}
{"testID":5,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11006}
{"group":{"id":6,"suiteID":0,"parentID":2,"name":"DaemonConnection sending end","metadata":{"skip":false,"skipReason":null},"testCount":7,"line":78,"column":3,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"group","time":11006}
{"test":{"id":7,"name":"DaemonConnection sending end sending requests","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":79,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11006}
{"testID":7,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11013}
{"test":{"id":8,"name":"DaemonConnection sending end sending requests without param","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":87,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11014}
{"testID":8,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11020}
{"test":{"id":9,"name":"DaemonConnection sending end sending response","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":95,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11020}
{"testID":9,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11026}
{"test":{"id":10,"name":"DaemonConnection sending end sending response without data","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":104,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11027}
{"testID":10,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11033}
{"test":{"id":11,"name":"DaemonConnection sending end sending error response","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":113,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11033}
{"testID":11,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11037}
{"test":{"id":12,"name":"DaemonConnection sending end sending events","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":122,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11037}
{"testID":12,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11041}
{"test":{"id":13,"name":"DaemonConnection sending end sending events without params","suiteID":0,"groupIDs":[2,6],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":130,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11041}
{"testID":13,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11045}
{"group":{"id":14,"suiteID":0,"parentID":2,"name":"DaemonConnection request and response","metadata":{"skip":false,"skipReason":null},"testCount":3,"line":139,"column":3,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"group","time":11046}
{"test":{"id":15,"name":"DaemonConnection request and response receiving response from requests","suiteID":0,"groupIDs":[2,14],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":140,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11046}
{"testID":15,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11052}
{"test":{"id":16,"name":"DaemonConnection request and response receiving response from requests without result","suiteID":0,"groupIDs":[2,14],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":153,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11052}
{"testID":16,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11056}
{"test":{"id":17,"name":"DaemonConnection request and response receiving error response from requests without result","suiteID":0,"groupIDs":[2,14],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":166,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11056}
{"testID":17,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11065}
{"group":{"id":18,"suiteID":0,"parentID":2,"name":"DaemonInputStreamConverter","metadata":{"skip":false,"skipReason":null},"testCount":9,"line":180,"column":3,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"group","time":11066}
{"test":{"id":19,"name":"DaemonInputStreamConverter can parse a single message","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":189,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11066}
{"testID":19,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11079}
{"test":{"id":20,"name":"DaemonInputStreamConverter can parse multiple messages","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":201,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11080}
{"testID":20,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11086}
{"test":{"id":21,"name":"DaemonInputStreamConverter can parse multiple messages while ignoring non json data in between","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":216,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11087}
{"testID":21,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11094}
{"test":{"id":22,"name":"DaemonInputStreamConverter can parse multiple messages even when they are split in multiple packets","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":232,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11095}
{"testID":22,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11100}
{"test":{"id":23,"name":"DaemonInputStreamConverter can parse multiple messages even when they are combined in a single packet","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":251,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11101}
{"testID":23,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11105}
{"test":{"id":24,"name":"DaemonInputStreamConverter can parse a single message with binary stream","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":267,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11106}
{"testID":24,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11117}
{"test":{"id":25,"name":"DaemonInputStreamConverter can parse a single message with binary stream when messages are combined in a single packet","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":281,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11118}
{"testID":25,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11128}
{"test":{"id":26,"name":"DaemonInputStreamConverter can parse multiple messages with binary stream","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":294,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11129}
{"testID":26,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11132}
{"test":{"id":27,"name":"DaemonInputStreamConverter can parse multiple messages with binary stream when messages are split","suiteID":0,"groupIDs":[2,18],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":313,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11132}
{"testID":27,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11137}
{"group":{"id":28,"suiteID":0,"parentID":2,"name":"DaemonStreams","metadata":{"skip":false,"skipReason":null},"testCount":4,"line":336,"column":3,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"group","time":11137}
{"test":{"id":29,"name":"DaemonStreams parses the message received on the stream","suiteID":0,"groupIDs":[2,28],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":350,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11137}
{"testID":29,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11143}
{"test":{"id":30,"name":"DaemonStreams sends the encoded message through the sink","suiteID":0,"groupIDs":[2,28],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":357,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11143}
{"testID":30,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11147}
{"test":{"id":31,"name":"DaemonStreams dispose closes the sink","suiteID":0,"groupIDs":[2,28],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":363,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11148}
{"testID":31,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11155}
{"test":{"id":32,"name":"DaemonStreams handles sending to a closed sink","suiteID":0,"groupIDs":[2,28],"metadata":{"skip":false,"skipReason":null},"line":159,"column":16,"url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/src/common.dart","root_line":368,"root_column":5,"root_url":"file:///home/void/flutter/flutter/packages/flutter_tools/test/general.shard/daemon_test.dart"},"type":"testStart","time":11156}
{"testID":32,"result":"success","skipped":false,"hidden":false,"type":"testDone","time":11171}
{"success":true,"type":"done","time":11206}

- removes invalid arch check on Android workflow in order to enable Android development on any device supported Signed-off-by: TheOneWithTheBraid <[email protected]>

TheOneWithTheBraid · 2022-11-04T08:23:21Z

@christopherfujino Sorry for the delay, finally made the tests passing. I will hand over to you and do some further investigation about !107121 now. Thanks a lot for your patience.

christopherfujino · 2022-11-05T00:04:35Z

@christopherfujino Sorry for the delay, finally made the tests passing. I will hand over to you and do some further investigation about !107121 now. Thanks a lot for your patience.

No problem about the delay, I appreciate everyone who contributes patches in their free time :)

Looks like everything but Google Testing is passing, and I can handle that.

…utter#113829)

* bdcacbf 1c1ad0e72 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) (flutter/flutter#115088) * ca61652 Roll ios-deploy iOS artifact (flutter/flutter#115042) * b31b9dc 057c53a05 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) (flutter/flutter#115093) * 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095) * 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002) * 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075) * 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999) * c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115) * 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829) * ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102) * 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181) * d413081 Fix shrinkwrap on animated list (flutter/flutter#115104) * bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118) * 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122) * 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124) * c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128) * 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132) * 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123) * f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134) * 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135) * 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139) * c021d91 [flutter_tools] support github reporter (flutter/flutter#115137) * 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142) * 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)

* 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095) * 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002) * 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075) * 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999) * c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115) * 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829) * ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102) * 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181) * d413081 Fix shrinkwrap on animated list (flutter/flutter#115104) * bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118) * 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122) * 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124) * c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128) * 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132) * 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123) * f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134) * 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135) * 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139) * c021d91 [flutter_tools] support github reporter (flutter/flutter#115137) * 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142) * 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)

* bdcacbf 1c1ad0e72 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) (flutter/flutter#115088) * ca61652 Roll ios-deploy iOS artifact (flutter/flutter#115042) * b31b9dc 057c53a05 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) (flutter/flutter#115093) * 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095) * 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002) * 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075) * 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999) * c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115) * 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829) * ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102) * 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181) * d413081 Fix shrinkwrap on animated list (flutter/flutter#115104) * bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118) * 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122) * 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124) * c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128) * 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132) * 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123) * f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134) * 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135) * 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139) * c021d91 [flutter_tools] support github reporter (flutter/flutter#115137) * 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142) * 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)

- removes invalid arch check on Android workflow in order to enable Android development on any device supported Signed-off-by: TheOneWithTheBraid <[email protected]> Signed-off-by: TheOneWithTheBraid <[email protected]>

* bdcacbf 1c1ad0e72 Roll Fuchsia Linux SDK from RNSA2Wp1MObtc7OHy... to mduclAELKkftJ-fwI... (flutter/engine#37495) (flutter/flutter#115088) * ca61652 Roll ios-deploy iOS artifact (flutter/flutter#115042) * b31b9dc 057c53a05 [Impeller] Remove duplicate code in 'TiledTextureContents' (flutter/engine#37492) (flutter/flutter#115093) * 19b351b f467eee51 Turned on performance-move-const-arg everywhere. (flutter/engine#37482) (flutter/flutter#115095) * 5a60045 Reland: Adds support for the Material Badge widget, BadgeTheme, BadgeThemeData (#114560) (flutter/flutter#115002) * 09a4f23 Prevent tests from producing dill files alongside the test file (flutter/flutter#115075) * 1f891a0 Fix `RangeSlider` semantics node size (flutter/flutter#114999) * c1ceda4 Include stdout in codesign failure output (flutter/flutter#115115) * 2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/flutter#113829) * ad72a45 12dabe83d Felt analyze (flutter/engine#37481) (flutter/flutter#115102) * 4e7dbef Explicitly call out documentation links in "flutter create" (flutter/flutter#114181) * d413081 Fix shrinkwrap on animated list (flutter/flutter#115104) * bd00a93 Roll Flutter Engine from 12dabe83da19 to 4cb9c1e00a84 (5 revisions) (flutter/flutter#115118) * 8858c17 Roll Flutter Engine from 4cb9c1e00a84 to 30e2cedfa2ac (2 revisions) (flutter/flutter#115122) * 0f2f4b8 Roll Flutter Engine from 30e2cedfa2ac to cae1716611a4 (2 revisions) (flutter/flutter#115124) * c6561e6 53cfb94c5 Roll Skia from 65b60707772d to b50a2f714837 (46 revisions) (flutter/engine#37501) (flutter/flutter#115128) * 6e89042 0721c860e [Impeller] null check samplers (flutter/engine#37489) (flutter/flutter#115132) * 88e49ed Load assets in flutter_test without turning event loop. (flutter/flutter#115123) * f997281 Roll Flutter Engine from 0721c860e2c3 to cb78576e5fec (3 revisions) (flutter/flutter#115134) * 0d081f9 Roll Flutter Engine from cb78576e5fec to a41712cec63a (2 revisions) (flutter/flutter#115135) * 83cda7e 19ead2834 Roll Fuchsia Linux SDK from mduclAELKkftJ-fwI... to R3L54Ma3VT2TQ6RpI... (flutter/engine#37513) (flutter/flutter#115139) * c021d91 [flutter_tools] support github reporter (flutter/flutter#115137) * 413bb21 e32fc0044 Roll Skia from b50f741ef341 to 77620568f467 (5 revisions) (flutter/engine#37514) (flutter/flutter#115142) * 098aac7 7326e5b33 Roll Dart SDK from 3a022103e91d to 1e37edb1f6c1 (1 revision) (flutter/engine#37515) (flutter/flutter#115145)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 21, 2022

christopherfujino approved these changes Oct 27, 2022

View reviewed changes

eliasyishak approved these changes Oct 27, 2022

View reviewed changes

flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Oct 27, 2022

chore: enable Flutter Android workflow on aarch64

fdad329

- removes invalid arch check on Android workflow in order to enable Android development on any device supported Signed-off-by: TheOneWithTheBraid <[email protected]>

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2022

auto-submit bot merged commit 2e432ec into flutter:master Nov 10, 2022

This was referenced Nov 11, 2022

Roll Flutter from c7d11549a51e to 098aac7ffeef (24 revisions) flutter/plugins#6692

Merged

Roll Flutter from b31b9dc05f99 to 098aac7ffeef (21 revisions) flutter/packages#2802

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2022

2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/fl…

e641057

…utter#113829)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 11, 2022

2e432ec chore: enable Flutter Android workflow on aarch64 (flutter/fl…

e9bf79a

…utter#113829)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enable Flutter Android workflow on aarch64#113829

chore: enable Flutter Android workflow on aarch64#113829
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TheOneWithTheBraid:braid/android-aarch64

TheOneWithTheBraid commented Oct 21, 2022 •

edited by eliasyishak

Loading

Uh oh!

christopherfujino commented Oct 27, 2022

Uh oh!

christopherfujino left a comment

Uh oh!

christopherfujino commented Oct 27, 2022

Uh oh!

eliasyishak left a comment

Uh oh!

christopherfujino commented Nov 3, 2022

Uh oh!

TheOneWithTheBraid commented Nov 4, 2022

Uh oh!

TheOneWithTheBraid commented Nov 4, 2022

Uh oh!

TheOneWithTheBraid commented Nov 4, 2022

Uh oh!

christopherfujino commented Nov 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TheOneWithTheBraid commented Oct 21, 2022 • edited by eliasyishak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

christopherfujino commented Oct 27, 2022

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Oct 27, 2022

Uh oh!

eliasyishak left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Nov 3, 2022

Uh oh!

TheOneWithTheBraid commented Nov 4, 2022

Uh oh!

TheOneWithTheBraid commented Nov 4, 2022

Uh oh!

TheOneWithTheBraid commented Nov 4, 2022

Uh oh!

christopherfujino commented Nov 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TheOneWithTheBraid commented Oct 21, 2022 •

edited by eliasyishak

Loading