fix a bug when android uses CupertinoPageTransitionsBuilder... by ipcjs · Pull Request #114303 · flutter/flutter

ipcjs · 2022-10-29T21:37:17Z

When android uses iOS style PageTransitionsBuilder and iOS uses android style PageTransitionsBuilder, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem.

#99919 introduced a breaking change, the pr re-implemented it without introducing a breaking change.**

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2022-11-24T23:12:24Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer · 2023-03-07T23:59:52Z

@ipcjs Looks like this change is breaking some tests. Can you please take a look and update the PR?

chunhtai · 2023-03-10T23:35:50Z

It looks like the tests are failing...

packages/flutter/lib/src/material/page.dart

ipcjs · 2023-03-11T14:04:32Z

All tests have passed!

packages/flutter/lib/src/material/page.dart

Hixie · 2023-05-23T22:49:17Z

@ipcjs Thanks for your contribution! Is this still something you are interested in working on? It's totally fine if not, we're just checking to see what we should do with the PR. It looks like there's just one outstanding comment from @chunhtai that needs resolving before we can land it. Thanks!

ipcjs · 2023-05-28T14:25:23Z

@Hixie Yes

packages/flutter/lib/src/material/page_transitions_theme.dart

packages/flutter/lib/src/material/page.dart

packages/flutter/test/material/page_transitions_theme_test.dart

chunhtai

Except for request for another test, the code LGTM

chunhtai

LGTM

packages/flutter/test/material/page_transitions_theme_test.dart

ipcjs · 2023-06-27T17:50:03Z

I've rebase to latest master branch, ~~but the luci-flutter test still doesn't pass.🤔️~~

ipcjs · 2023-06-27T18:02:04Z

Looks like all checks have passed!

HansMuller · 2023-06-29T20:09:19Z

packages/flutter/lib/src/material/page_transitions_theme.dart

    Animation<double> animation,
    Animation<double> secondaryAnimation,
    Widget child,
+    TargetPlatform platform,


This is effectively a breaking change for both callers and subclassers (it does break existing internal Google apps). On the upside, it does not breaking any existing Flutter repo or customer tests (flutter/tests). A brief migration will be needed per https://docs.flutter.dev/resources/compatibility. One of the reviewers can update the internal Google apps.

Should I create a migration guide in the website repository look like flutter/website#8976?

flutter/website#8976 looks like it covers the changes. Will land this PR and make the internal updates.

auto-submit · 2023-07-05T16:40:12Z

auto label is removed for flutter/flutter, pr: 114303, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

HansMuller

LGTM

flutter/flutter#114303)

flutter/flutter@35085c3...bc49cd1 2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877) 2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854) 2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040) 2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804) 2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741) 2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879) 2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860) 2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035) 2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663) 2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008) 2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023) 2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902) 2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303) 2023-07-05 [email protected] Add .env file support for option `--dart-define-from-file` (flutter/flutter#128668) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

#114303)" This reverts commit aaaea51.

HansMuller · 2023-07-07T15:35:08Z

Unfortunately, preliminary testing didn't turn up the failures that were caused by the breaking API change here. We've had to revert this PR: #130144.

…." (#130144) Reverts #114303 The breaking API change in #114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: #130062. Fixes #130062

…." (flutter#130144) Reverts flutter#114303 The breaking API change in flutter#114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: flutter#130062. Fixes flutter#130062

#130155) …." (#130144) Reverts #114303 The breaking API change in #114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: #130062. Co-authored-by: Hans Muller <[email protected]>

flutter/flutter#114303)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 29, 2022

ipcjs changed the title ~~fix a bug when android uses CupertinoPageTransitionsBuilder.~~ fix a bug when android uses CupertinoPageTransitionsBuilder without breaking change. Oct 29, 2022

HansMuller requested review from MitchellGoodwin and removed request for MitchellGoodwin November 4, 2022 23:08

ipcjs force-pushed the hotfix/page-transitions-theme-2 branch from e73f462 to 1dcda2c Compare November 28, 2022 17:30

goderbauer requested a review from chunhtai March 7, 2023 23:59

chunhtai reviewed Mar 10, 2023

View reviewed changes

packages/flutter/lib/src/material/page.dart Outdated Show resolved Hide resolved

ipcjs force-pushed the hotfix/page-transitions-theme-2 branch from 1dcda2c to e351120 Compare March 11, 2023 11:54

chunhtai self-requested a review March 13, 2023 16:40

chunhtai reviewed Mar 24, 2023

View reviewed changes

packages/flutter/lib/src/material/page.dart Outdated Show resolved Hide resolved

ipcjs force-pushed the hotfix/page-transitions-theme-2 branch from 2d690f0 to 2d032a1 Compare May 28, 2023 14:11

github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 28, 2023

chunhtai self-requested a review May 30, 2023 16:12

chunhtai reviewed Jun 5, 2023

View reviewed changes

packages/flutter/lib/src/material/page_transitions_theme.dart Outdated Show resolved Hide resolved

chunhtai requested a review from HansMuller June 5, 2023 20:29

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 7, 2023

chunhtai self-requested a review June 7, 2023 15:45

chunhtai reviewed Jun 16, 2023

View reviewed changes

ipcjs force-pushed the hotfix/page-transitions-theme-2 branch from 2d032a1 to 53d847a Compare June 18, 2023 15:23

ipcjs requested a review from chunhtai June 20, 2023 16:22

chunhtai reviewed Jun 21, 2023

View reviewed changes

chunhtai self-requested a review June 22, 2023 15:56

chunhtai approved these changes Jun 26, 2023

View reviewed changes

packages/flutter/test/material/page_transitions_theme_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/page_transitions_theme_test.dart Outdated Show resolved Hide resolved

ipcjs added 2 commits June 28, 2023 00:37

add test: back gesture while TargetPlatform changes

9043653

modify comment

f50b6e2

ipcjs force-pushed the hotfix/page-transitions-theme-2 branch from c7a5d5d to f50b6e2 Compare June 27, 2023 16:38

HansMuller reviewed Jun 29, 2023

View reviewed changes

ipcjs changed the title ~~fix a bug when android uses CupertinoPageTransitionsBuilder without breaking change.~~ fix a bug when android uses CupertinoPageTransitionsBuilder... Jul 3, 2023

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023

HansMuller approved these changes Jul 5, 2023

View reviewed changes

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023

auto-submit bot merged commit aaaea51 into flutter:master Jul 5, 2023

engine-flutter-autoroll mentioned this pull request Jul 6, 2023

Roll Flutter from 35085c394dda to bc49cd1bcab5 (14 revisions) flutter/packages#4387

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2023

aaaea51 fix a bug when android uses CupertinoPageTransitionsBuilder... (

20309b2

flutter/flutter#114303)

huycozy mentioned this pull request Jul 7, 2023

Undue breaking change in buildTransitions breaks dependencies #130062

Closed

2 tasks

HansMuller added a commit that referenced this pull request Jul 7, 2023

Revert "fix a bug when android uses CupertinoPageTransitionsBuilder... (

6ce6603

#114303)" This reverts commit aaaea51.

HansMuller mentioned this pull request Jul 7, 2023

Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." #130144

Merged

Jasguerrero mentioned this pull request Jul 7, 2023

Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..… #130155

Merged

ipcjs mentioned this pull request Jul 7, 2023

Pop gesture not work when Android use CupertinoPageTransitionsBuilder and iOS use other PageTransitionsBuilder. #130158

Open

2 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

aaaea51 fix a bug when android uses CupertinoPageTransitionsBuilder... (

f976dca

flutter/flutter#114303)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

aaaea51 fix a bug when android uses CupertinoPageTransitionsBuilder... (

df80c2a

flutter/flutter#114303)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

aaaea51 fix a bug when android uses CupertinoPageTransitionsBuilder... (

39ff52d

flutter/flutter#114303)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

aaaea51 fix a bug when android uses CupertinoPageTransitionsBuilder... (

f9fa192

flutter/flutter#114303)

HansMuller mentioned this pull request Sep 20, 2023

Fixes the transition builder changing the Cupertino transition on Android. #134790

Merged

8 tasks

Conversation

ipcjs commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Nov 24, 2022

Uh oh!

goderbauer commented Mar 7, 2023

Uh oh!

chunhtai commented Mar 10, 2023

Uh oh!

Uh oh!

ipcjs commented Mar 11, 2023

Uh oh!

Uh oh!

Hixie commented May 23, 2023

Uh oh!

ipcjs commented May 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ipcjs commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ipcjs commented Jun 27, 2023

Uh oh!

HansMuller Jun 29, 2023

Choose a reason for hiding this comment

Uh oh!

ipcjs Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 5, 2023

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ipcjs commented Oct 29, 2022 •

edited

Loading

ipcjs commented Jun 27, 2023 •

edited

Loading