Build command dependency injection#114383
Merged
auto-submit[bot] merged 7 commits intoflutter:masterfrom Nov 8, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
tool
# Conflicts: # packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart
| BuildWebCommand({ | ||
| required super.logger, | ||
| required FileSystem fileSystem, | ||
| required bool verboseHelp, |
Contributor
There was a problem hiding this comment.
as a further cleanup, I think this can be required super.verboseHelp, and then we don't have to explicitly call super(verboseHelp: verboseHelp)
| class BuildMacosCommand extends BuildSubCommand { | ||
| BuildMacosCommand({ | ||
| required super.logger, | ||
| required bool verboseHelp, |
Contributor
There was a problem hiding this comment.
this can be required super.verboseHelp,
| final BuildCommand command = BuildCommand( | ||
| androidSdk: FakeAndroidSdk(), | ||
| buildSystem: TestBuildSystem.all(BuildResult(success: true)), | ||
| fileSystem: MemoryFileSystem.test(), |
Contributor
There was a problem hiding this comment.
do we need the filesystem override on line 199? And how does the global XcodeProjectInterpreter get called?
Contributor
There was a problem hiding this comment.
In general, are we able to remove any of the context overrides from the tests after this change?
Contributor
Author
There was a problem hiding this comment.
Yes we still need those overrides because BuildIOSCommand is not yet migrated. As for the XcodeProjectInterpreter comes all the way from lib/src/ios/mac.dart
Contributor
There was a problem hiding this comment.
there are no overrides throughout all the test files here that can be removed?
Contributor
Author
There was a problem hiding this comment.
No 😕, wanted to remove the fs but it is used on FlutterCommand
Contributor
There was a problem hiding this comment.
:'( ok, thanks for checking
christopherfujino
approved these changes
Nov 3, 2022
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, thanks for this one!
# Conflicts: # packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
Jasguerrero
added
the
autosubmit
This was referenced Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 9, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 9, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Nov 9, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
* update flutter build command * update tests * fix analyze suggestions
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* update flutter build command * update tests * fix analyze suggestions
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* a84e369 Revert "Allow Flutter golden file tests to be flaky (#114450)" (flutter/flutter#114902) * 1725a26 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114834) * 7020f59 [tool] Support `--flavor` option for `flutter install`. (flutter/flutter#114048) * 9797d5f [macOS] Refactor the `flutter run` macOS console output test (flutter/flutter#114645) * 530324d Build command dependency injection (flutter/flutter#114383) * 69a542d Apply multidex config in kotlin dsl gradle file (flutter/flutter#114660) * 92f10ed match error statements without relying on volatile human-readable descriptions (flutter/flutter#114922) * d3dcd7d Update `CircleAvatar` to support Material 3 (flutter/flutter#114812)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #107607
The missing BuildSubCommands will be added in a different PR to minimize breakeges with g3
Pre-launch Checklist
///).