Skip to content

Allow Flutter golden file tests to be flaky#114450

Merged
auto-submit[bot] merged 18 commits intoflutter:masterfrom
Piinks:goldenFlake3
Nov 8, 2022
Merged

Allow Flutter golden file tests to be flaky#114450
auto-submit[bot] merged 18 commits intoflutter:masterfrom
Piinks:goldenFlake3

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Nov 1, 2022

Fixes #111325

Adds the ability to specify Flutter framework tests as flaky, allowing them to be uploaded to Skia Gold for visual confirmation that a flake has been fixed. Prior to this change, there was no way to see if a flake had been fixed, the test would be re-enabled and then the tree would break, letting us know it was still flaky.
This will prevent a test from breaking the tree while it is in flaky mode.

Also added tech debt tracking and analyzer enforcement.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need a way to verify flaky golden test fixes

2 participants