[CP] Fix Snackbar TalkBack regression#116608
Merged
XilaiZhang merged 2 commits intoflutter:flutter-3.7-candidate.1from Dec 9, 2022
Merged
[CP] Fix Snackbar TalkBack regression#116608XilaiZhang merged 2 commits intoflutter:flutter-3.7-candidate.1from
XilaiZhang merged 2 commits intoflutter:flutter-3.7-candidate.1from
Conversation
* Add M2 defaults and template skeleton * add MaterialStateColor functionality to ActionTextColor (issue flutter#110402) * Add M2 defaults and template skeleton * updated material 3 tokens * Updated snackbar demo * add theme tests * add gen defaults * formatting * more whitespace fixes * add widget type * update docs * code review changes * Add line overflow functionality * whitespace fixes * update M3 animation * whitespace fixes * add insetPadding param * Modifed icon parameter to showCloseIcon * white space fixes * test fixes * rename iconColor to closeIconColor * debug test fix * de-britishification * g3fix * g3fix * debug test fix * Fix Snackbar talkback regression * fix merge weirdness * test fix * fix linux analysis error * fix linux analysis error * fix linux analysis error * fix linux analysis error * fix linux analysis error * fix linux analysis error
guidezpl
approved these changes
Dec 6, 2022
Member
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
Member
Author
|
Filed #116611 for the code signing failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP of #116417.