Reland "Speed up first asset load by encoding asset manifest in binary rather than JSON (#116662)"#116684
Closed
andrewkolos wants to merge 111 commits intoflutter:masterfrom
Closed
Reland "Speed up first asset load by encoding asset manifest in binary rather than JSON (#116662)"#116684andrewkolos wants to merge 111 commits intoflutter:masterfrom
andrewkolos wants to merge 111 commits intoflutter:masterfrom
Conversation
…ng-for-asset-manifest
…ng-for-asset-manifest
This reverts commit 23decc2.
…ng-for-asset-manifest
This is to avoid breaking folks that currently extend AssetBundle.
…ng-for-asset-manifest
…ng-for-asset-manifest
…ng-for-asset-manifest
…ng-for-asset-manifest
…ng-for-asset-manifest
…ng-for-asset-manifest
…ng-for-asset-manifest
flutter-dashboard
bot
added
framework
andrewkolos
changed the title
11 tasks
Contributor
Author
|
Due to difficult to debug issues in g3, I'll be taking a different strategy to landing this change. Instead of one change that 1) generates the new asset manifest and 2) also uses it for image resolution (with code to fallback to Development is being tracked with #117228 |
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #113637, which was reverted by #116662.
Pre-launch Checklist
///).