Made snapshot rebuild logic take target into account#11730
Made snapshot rebuild logic take target into account#11730mravn-google wants to merge 3 commits intoflutter:masterfrom
Conversation
| final Iterable<File> files = inputPaths.map(fs.file); | ||
| /// input files and properties provided. | ||
| class Fingerprint { | ||
| Fingerprint.fromInputs({Set<String> filePaths, Map<String, String> properties}) : _fingerprint = <String, String>{} { |
There was a problem hiding this comment.
Nit: filePaths could just be an Iterable<String>, right? Then you wouldn't need to convert the lists to sets in the tests.
| testUsingContext('throws if any input file does not exist', () async { | ||
| await fs.file('a.dart').create(); | ||
| expect(() => new Checksum.fromFiles(<String>['a.dart', 'b.dart'].toSet()), throwsA(anything)); | ||
| expect(() => new Fingerprint.fromInputs(filePaths: <String>['a.dart', 'b.dart'].toSet()), throwsA(anything)); |
There was a problem hiding this comment.
throwsArgumentError instead of throwsA(anything)?
| }); | ||
|
|
||
| testUsingContext('rebuilds if target changes', () async { | ||
| await runAsync(<String>['flutter', 'create', projectDir.path], allowReentrantFlutter: true); |
There was a problem hiding this comment.
This'll only work if flutter is on the path (and maybe not on Windows). The other tests use createTestCommandRunner(), maybe that instead?
|
This appeared to have already been done by #11820, but that PR only takes change of main path into account, if the different main scripts are not part of the app for any other reason than being the main entry point. Specifically, if you have |
|
@cbracken will surely want to review this since this is his favourite part of the codebase. |
|
Superseded by #11924. |
4 participants
Fixes #11400