Avoid unnecessary unwrap of _lastPendingEventTimestamp#117551
Avoid unnecessary unwrap of _lastPendingEventTimestamp#117551tarobins wants to merge 4 commits intoflutter:masterfrom
_lastPendingEventTimestamp#117551Conversation
…mes causes "Null check operator used on a null" Fixes flutter#112403
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…mes causes "Null check operator used on a null" Fixes flutter#112403
|
This can fix the problem for sure, but I don't think simply making this change without understand how |
|
@tarobins Can you please add a test for this? |
|
(Triage): I am going to close this one since there was no follow-up. Looks like we have an issue on file to keep track of this work. If you (or anyone else) finds the time to work on this again, feel free to reopen. Thanks! |
Avoid unnecessary unwrap of
_lastPendingEventTimestampwhich sometimes causes "Null check operator used on a null"Fixes #112403
List which issues are fixed by this PR. You must list at least one issue.
112403
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.