[flutter roll] Revert "fixes android_semantics_integration_test to expect long press for too…"#117558
Closed
XilaiZhang wants to merge 1 commit intomasterfrom
Closed
[flutter roll] Revert "fixes android_semantics_integration_test to expect long press for too…"#117558XilaiZhang wants to merge 1 commit intomasterfrom
XilaiZhang wants to merge 1 commit intomasterfrom
Conversation
flutter-dashboard
bot
added
a: accessibility
chunhtai
approved these changes
Dec 22, 2022
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, should this merge with the original revert as one commit. It will be easier to reland as well
Contributor
Author
umm sorry if i am misunderstanding, like combining #117557 with this PR into one PR?, so that this combined PR would revert 2 PRs? |
Contributor
|
yes |
Contributor
Author
|
Sure, thanks for explaining! updated #117557 to include both reverts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #117547.
revert along with #117557 to fix tooltip tests.