Temporarily show the latest entered character in an obscured text field#11830
Merged
jason-simmons merged 1 commit intoflutter:masterfrom Aug 30, 2017
Merged
Temporarily show the latest entered character in an obscured text field#11830jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons merged 1 commit intoflutter:masterfrom
Conversation
Member
Author
Hixie
reviewed
Aug 29, 2017
Contributor
There was a problem hiding this comment.
Please put a comment inside the {} explaining what state changed (or, better, put the actual state change there).
Contributor
|
needs a test |
jason-simmons
force-pushed
the
bug_11817
branch
from
c536acf to
044b5ba
Compare
Member
Author
|
done - PTAL |
Hixie
reviewed
Aug 29, 2017
| void _cursorTick(Timer timer) { | ||
| _showCursor.value = !_showCursor.value; | ||
| if (_obscureShowCharTicksPending > 0) { | ||
| setState(() { _obscureShowCharTicksPending--; }); |
Contributor
There was a problem hiding this comment.
minor issue, feel free to ignore: consider -= 1 rather than postfix --
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11817