auto label is removed for flutter/flutter, pr: 118412, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto label is removed for flutter/flutter, pr: 118412, due to Validations Fail.

auto label is removed for flutter/flutter, pr: 118412, due to - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

• The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
• The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

Looks like a legitimate test regression (from package:mime?):

00:35 +1051 ~1 -1: test/general.shard/web/devfs_web_test.dart: serves asset files from in filesystem with known mime type and empty content [E]                                                        
  Expected: (contains pair 'content-length' => '0' and contains pair 'content-type' => 'application/javascript')
    Actual: {
              'cache-control': 'max-age=0, must-revalidate',
              'content-length': '0',
              'content-type': 'text/javascript',
              'etag': '2023-01-12T13:55:35.704%2Fweb%2Ffoo.js'
            }
     Which:  contains key 'content-type' but with value is different.
            Expected: applicatio ...
              Actual: text/javas ...
                      ^
             Differ at offset 0
  
  package:test_api                                    expect
  test/general.shard/web/devfs_web_test.dart 593:5    main.<fn>.<fn>
  ===== asynchronous gap ===========================
  test/src/testbed.dart 131:13                        Testbed.run.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 150:19  AppContext.run.<fn>
  ===== asynchronous gap ===========================
  package:flutter_tools/src/base/context.dart 150:19  AppContext.run.<fn>

Looks like a legitimate test regression (from package:mime?)

Seems like the change is intended:

https://datatracker.ietf.org/doc/html/rfc9239

This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is text/javascript; all others are considered historical and obsolete aliases of text/javascript.

Note that this use of the "text" media type tree willfully does not align with its original intent per [RFC2045]. The reason for this is historical. [RFC4329] registered both the text/* and application/* types, marking the text/* types obsolete. This was done to encourage people toward application/, matching the guidance in [RFC4288], the predecessor to [RFC6838]. Since then, however, the industry widely adopted text/ anyway.

I'll open a PR that updates packages and includes fixes for these failing tests.

I've opened #118617 which is running through the bots.

I've opened #118617 which is running through the bots.

Thanks!

@christopherfujino #118617 has been merged. Do we just close this one and the bot will continue again?

@DanTup thanks, and yeah, I've just been closing these when a manual fix resolves it.