Skip to content

Update packages + fix tests for javascript mime change#118617

Merged
bkonyi merged 2 commits intoflutter:masterfrom
DanTup:update-packages-jan-2023
Jan 19, 2023
Merged

Update packages + fix tests for javascript mime change#118617
bkonyi merged 2 commits intoflutter:masterfrom
DanTup:update-packages-jan-2023

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Jan 17, 2023

The first commit is the result of running flutter update-packages --force-upgrade and the second commit fixes two failin tests (which prevented the bot from rolling in #118412) which are caused by changes in package:mime to use text/javascript instead of application/javascript:

See dart-archive/mime#76.
See https://datatracker.ietf.org/doc/html/rfc9239.

This document defines equivalent processing requirements for the various script media types. The most widely supported media type in use is text/javascript; all others are considered historical and obsolete aliases of text/javascript.

Note: There are some additional places in the Flutter codebase that use text/javascript that I did not update in this PR because I wanted it to be the minimum required to roll the packages. If it makes sense, I can also update them (here, or in another PR).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants