Update packages + fix tests for javascript mime change#118617
Merged
bkonyi merged 2 commits intoflutter:masterfrom Jan 19, 2023
Merged
Update packages + fix tests for javascript mime change#118617bkonyi merged 2 commits intoflutter:masterfrom
bkonyi merged 2 commits intoflutter:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is the result of running
flutter update-packages --force-upgradeand the second commit fixes two failin tests (which prevented the bot from rolling in #118412) which are caused by changes inpackage:mimeto usetext/javascriptinstead ofapplication/javascript:See dart-archive/mime#76.
See https://datatracker.ietf.org/doc/html/rfc9239.
Note: There are some additional places in the Flutter codebase that use
text/javascriptthat I did not update in this PR because I wanted it to be the minimum required to roll the packages. If it makes sense, I can also update them (here, or in another PR).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.