Added backgroundColor and disabledBackgroundColor to SnackBarAction.#118786
Merged
HansMuller merged 1 commit intoflutter:masterfrom Mar 27, 2023
Merged
Added backgroundColor and disabledBackgroundColor to SnackBarAction.#118786HansMuller merged 1 commit intoflutter:masterfrom
HansMuller merged 1 commit intoflutter:masterfrom
Conversation
8 tasks
d51db12 to
7413f0a
Compare
Member
Author
|
@HansMuller could you please review this? |
esouthren
suggested changes
Feb 23, 2023
Contributor
esouthren
left a comment
There was a problem hiding this comment.
Hey @chinmoy12c, thanks for your patience on the review.
Mostly LGTM; some small comments.
7413f0a to
2dced05
Compare
Member
Author
|
Hey @esouthren sorry for the delay, made the changes :) |
2dced05 to
fb32452
Compare
fb32452 to
3ac08c6
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
8 tasks
This was referenced Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds backgroundColor and disabledBackgroundColor properties to SnackBarAction.
Fixes: #109933
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.