Fix test when a Skia RTL positioning bug is fixed#118902
Closed
justinmc wants to merge 1 commit intoflutter:masterfrom
Closed
Fix test when a Skia RTL positioning bug is fixed#118902justinmc wants to merge 1 commit intoflutter:masterfrom
justinmc wants to merge 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
goderbauer
approved these changes
Jan 24, 2023
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM once SKia change has rolled in and tests pass.
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Jan 31, 2023
…roll https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in SkParagraph. One of the selectable region tests relies on the old behavior. After that Skia change rolls into the framework, the update to the test in flutter#118902 should be landed.
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
…roll (#119653) https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in SkParagraph. One of the selectable region tests relies on the old behavior. After that Skia change rolls into the framework, the update to the test in #118902 should be landed.
Member
|
This appears to be the same as #119756. This one can probably be closed if the other more uptodate one lands? |
Contributor
Author
|
Sounds good, this is probably redundant now that that one was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this comment for where this came about.
There is an existing bug about the cursor going to the penultimate character in RTL text (#118566), which is being fixed in Skia. Once that fix is rolled into Flutter, the test that's modified in this PR will fail, and this PR will be needed to make it pass again.
This must not be merged until Skia fix https://skia-review.googlesource.com/c/skia/+/619838/1 is rolled into Flutter.