Migrate the Material Date pickers to M3 Reprise by HansMuller · Pull Request #119033 · flutter/flutter

HansMuller · 2023-01-24T00:18:43Z

This PR is entirely the work of @darrenaustin - #118603.

Part of: #91605

Updated the Date Pickers with support for Material Design 3.

In order to use the date pickers with the new Material 3 defaults, turn on the useMaterial3 flag in the ThemeData:

  return MaterialApp(
    theme: ThemeData(useMaterial3: true),
    // ...
  );

This PR includes a new DatePickerTheme that can be used to configure the look of the components used in the date picker widgets (i.e. showDatePicker, showDateRangePicker, DatePickerDialog, DateRangePickerDialog, CalendarDatePicker, and InputDatePickerTextField.

Fixes: #101481

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

gspencergoog · 2023-01-24T22:50:22Z

packages/flutter/lib/src/material/date_picker_theme.dart

Should this have a "See also" for the Material shape property?

That might be a little confusing, since https://api.flutter.dev/flutter/material/Material-class.html and https://api.flutter.dev/flutter/material/Material/shape.html tie the Material shape property to the Material type and borderRadius. Will add a statement that explains that the shadow depends on shape and elevation.

gspencergoog · 2023-01-24T22:50:56Z

packages/flutter/lib/src/material/date_picker_theme.dart

Same here, should this have a see also to the Material shape property?

gspencergoog · 2023-01-24T22:54:15Z

packages/flutter/lib/src/material/date_picker_theme.dart

Is it not used directly, or is it just not used?

Sorry, I should have simplified that to just "not used".

gspencergoog · 2023-01-24T22:55:46Z

Also, see this #118603 (comment)

guidezpl

It would be great to see a code sample

HansMuller · 2023-01-25T16:44:26Z

An example is a good idea; plan to address that in a separate PR: #118603 (comment)

guidezpl · 2023-01-27T05:34:05Z

packages/flutter/lib/src/material/theme_data.dart

nit: [DateRangePickerDialog] and [InputDatePickerFormField] too?

guidezpl

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

…variables, and reusing existing useMaterial3 variables

…lt value of ..."

…ter#119033)

* 472b887 0ec8e2802 Roll Fuchsia Mac SDK from 9y7C2oamTv6Py4JSC... to EAFnGijD0l5QxaPxF... (flutter/engine#39236) (flutter/flutter#119461) * 15cd00f a7bb0e410 Roll Fuchsia Linux SDK from 1D63BqURfJdG4r3CK... to xTXbcsPr5GJvFSLha... (flutter/engine#39238) (flutter/flutter#119482) * 530c3f2 [Re-land#2] Button padding M3 (flutter/flutter#119498) * 17eb2e8 Ability to disable the browser's context menu on web (flutter/flutter#118194) * df8ad3d roll packages (flutter/flutter#119370) * b68cebd roll packages (flutter/flutter#119530) * 59d80dc [Android] Add explicit exported tag to Linux_android flavors test (flutter/flutter#117542) * 458b298 Refactoring to use `ver` command instead of `systeminfo` (flutter/flutter#119304) * 54405bf fixes PointerEventConverter to handle malformed scrolling event (flutter/flutter#118124) * e69ea6d Support flipping mouse scrolling axes through modifier keys (flutter/flutter#115610) * 92df6b4 396c7fd0b Reland "Remove references to Observatory (#38919)" (flutter/engine#39139) (flutter/flutter#119546) * 7477d7a Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (flutter/flutter#119529) * 6c12e39 Introduce ParagraphBoundary subclass for text editing (flutter/flutter#116549) * b227df3 Hint text semantics to be excluded in a11y read out if hintText is not visible. (flutter/flutter#119198) * 18c7f8a Fix typo in --machine help text (flutter/flutter#119563) * 329f86a Make a few values non-nullable in cupertino (flutter/flutter#119478) * c4520bc b2efe0175 [web] Expose felt flag for building CanvasKit Chromium (flutter/engine#39201) (flutter/flutter#119567) * 8898f4f Marks Mac_android run_debug_test_android to be unflaky (flutter/flutter#117468) * 1f0b6fb Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (flutter/flutter#119253) * edaeec8 Roll Flutter Engine from b2efe01754ef to 5011144c0b46 (3 revisions) (flutter/flutter#119578) * 865dc5c Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (flutter/flutter#119584) * 1148a2a Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (flutter/flutter#119359) * 2340902 Roll Flutter Engine from daa8eeb7fc0b to 77218818138f (3 revisions) (flutter/flutter#119586) * 65900b7 Remove deprecated AnimatedSize.vsync parameter (flutter/flutter#119186) * 5b6572f Add debug diagnostics to channels integration test (flutter/flutter#119579) * 504e565 Roll Flutter Engine from 77218818138f to 9448f2966c11 (3 revisions) (flutter/flutter#119592) * 7ba4406 Revert "[Re-land#2] Button padding M3 (#119498)" (flutter/flutter#119597) * 2c34a88 Roll Flutter Engine from 9448f2966c11 to 72abe0e4b828 (3 revisions) (flutter/flutter#119603) * df0ab40 Roll Plugins from ff84c44 to 9da327c (15 revisions) (flutter/flutter#119629) * 67d07a6 [flutter_tools] Fix parsing of existing DDS URIs from exceptions (flutter/flutter#119506) * d272a3a Reland: [macos] add flavor options to tool commands (flutter/flutter#119564) * a16d82c aa00da3c1 Roll Skia from fc31f43cc40a to 3c6eb76a683a (1 revision) (flutter/engine#39280) (flutter/flutter#119605) * f6b0c6d Use first Dart VM Service found with mDNS if there are duplicates (flutter/flutter#119545) * d4c7485 Make Decoration.padding non-nullable (flutter/flutter#119581) * 2fccf4d Remove MediaQuery from WidgetsApp (flutter/flutter#119377) * 9b3b9cf Roll Flutter Engine from aa00da3c1612 to cd2e8885e491 (6 revisions) (flutter/flutter#119639) * 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195) * e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515) * 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640) * 0e22aca Add support for image insertion on Android (flutter/flutter#110052) * ff22813 separatorBuilder can't return null (flutter/flutter#119566) * 60c1f29 2471f430f Update buildroot to c02da5072d1bb2. (flutter/engine#39292) (flutter/flutter#119645) * fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653) * 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655) * 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644) * 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033) * dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670) * 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669) * 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675) * 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595) * 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683) * a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439) * e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686) * 97d273c CupertinoThemeData equality (flutter/flutter#119480) * 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688) * b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695) * 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706) * d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796)

…ter#119033)

* 6a54059 Make MultiChildRenderObjectWidget const (flutter/flutter#119195) * e2b3d89 Fix CupertinoNavigationBar should create a backward compatible Annota… (flutter/flutter#119515) * 7bf95f4 1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (flutter/flutter#119640) * 0e22aca Add support for image insertion on Android (flutter/flutter#110052) * ff22813 separatorBuilder can't return null (flutter/flutter#119566) * 60c1f29 2471f430f Update buildroot to c02da50. (flutter/engine#39292) (flutter/flutter#119645) * fbe9ff3 Disable an inaccurate test assertion that will be fixed by an engine roll (flutter/flutter#119653) * 8f90e2a Roll Flutter Engine from 2471f430ff4b to bb7b7006f4a3 (2 revisions) (flutter/flutter#119655) * 3884381 Make gen-l10n error handling independent of logger state (flutter/flutter#119644) * 198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flutter#119033) * dc86565 Roll Flutter Engine from bb7b7006f4a3 to 521b975449ba (4 revisions) (flutter/flutter#119670) * 82df235 Undo making Flex,Row,Column const (flutter/flutter#119669) * 6f9a896 Roll Flutter Engine from 521b975449ba to 38913c5484cf (2 revisions) (flutter/flutter#119675) * 8d0af36 🥅 Produce warning instead of error for storage base url overrides (flutter/flutter#119595) * 3894d24 1703a3966 Roll Skia from c29211525dac to 654f4805e8b8 (21 revisions) (flutter/engine#39309) (flutter/flutter#119683) * a752c2f Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (flutter/flutter#119439) * e1f0b1d d92e23cb5 Roll Skia from 654f4805e8b8 to da41cf18f651 (1 revision) (flutter/engine#39311) (flutter/flutter#119686) * 97d273c CupertinoThemeData equality (flutter/flutter#119480) * 4167835 5b549950f Roll Fuchsia Linux SDK from 71lEeibIyrq0V8jId... to TFcelQ5SwrzkcYK2d... (flutter/engine#39312) (flutter/flutter#119688) * b4a6e34 0d87b1562 Roll Dart SDK from 8b57d23a7246 to de03e1f41b50 (1 revision) (flutter/engine#39313) (flutter/flutter#119695) * 3af30ff Roll Flutter Engine from 0d87b156265c to c08a286d60e9 (3 revisions) (flutter/flutter#119706) * d278808 [Re-land] Exposed tooltip longPress (flutter/flutter#118796) * 254a796 Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729) * 1573c12 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 24, 2023

HansMuller mentioned this pull request Jan 24, 2023

Migrate the Material Date pickers to M3. #118603

Closed

8 tasks

HansMuller force-pushed the darren_date_picker branch 2 times, most recently from 024dad5 to e8239fc Compare January 24, 2023 20:02

gspencergoog reviewed Jan 24, 2023

View reviewed changes

guidezpl reviewed Jan 25, 2023

View reviewed changes

HansMuller force-pushed the darren_date_picker branch from f1a9127 to fd45035 Compare January 25, 2023 17:25

guidezpl reviewed Jan 27, 2023

View reviewed changes

packages/flutter/lib/src/material/theme_data.dart Outdated

Copy link

Member

guidezpl Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: [DateRangePickerDialog] and [InputDatePickerFormField] too?

guidezpl approved these changes Jan 27, 2023

View reviewed changes

HansMuller force-pushed the darren_date_picker branch from 5a18063 to 26ecc88 Compare January 31, 2023 00:02

HansMuller added 12 commits January 31, 2023 10:30

merge with the Dart3 updates

e7f8b3d

Updated per review feedback about binding Theme.of(context) to local …

62b3ef8

…variables, and reusing existing useMaterial3 variables

API doc changes per review feedback and the bot

c9016e5

Updated DatePickerTheme property API doc to read "Overrides the defau…

9a93d92

…lt value of ..."

explain that the header displays the selected date

f48e5bf

explain color property of the TextStyle parameters

20e1672

Add todayBackgroundColor to DatePickerTheme.copyWith

5d4e293

Updates per review feedback and the first few tests

8a55abb

Updates per review feedback and the first few tests

558b7ec

removed no longer needed assert foo != null statements

53bb7ba

more tests and DatePickerThemeData.rangePickerBackgroundColor

eb94fa5

test M2,M3 defaults

320f55e

HansMuller force-pushed the darren_date_picker branch from fe18463 to 320f55e Compare January 31, 2023 18:30

HansMuller merged commit 198a51a into flutter:master Jan 31, 2023

HansMuller deleted the darren_date_picker branch January 31, 2023 23:31

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to b4a6e349a25b (20 revisions) flutter/packages#3133

Closed

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 0a22a1dbf475 to b4a6e349a25b (56 revisions) flutter/plugins#7075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

97753e8

…ter#119033)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

513862e

…ter#119033)

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to 3af30ff5913f (21 revisions) flutter/packages#3134

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

2d27b67

…ter#119033)

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to d27880801435 (22 revisions) flutter/packages#3137

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

f4d639a

…ter#119033)

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 0a22a1dbf475 to d27880801435 (58 revisions) flutter/plugins#7078

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

aaf35bf

…ter#119033)

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to 254a796bc3f8 (23 revisions) flutter/packages#3138

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

579fe2e

…ter#119033)

engine-flutter-autoroll mentioned this pull request Feb 1, 2023

Roll Flutter from 9b3b9cf0893d to 1573c12963c6 (24 revisions) flutter/packages#3140

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2023

198a51a Migrate the Material Date pickers to M3 Reprise (flutter/flut…

baed402

…ter#119033)

sunboyy mentioned this pull request Mar 8, 2023

Material 3 dialog Macacoazul01/month_picker_dialog#63

Closed

TahaTesser mentioned this pull request May 15, 2023

Add tests for Material 3 Date pickers #126826

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate the Material Date pickers to M3 Reprise#119033

Migrate the Material Date pickers to M3 Reprise#119033
HansMuller merged 12 commits intoflutter:masterfrom
HansMuller:darren_date_picker

HansMuller commented Jan 24, 2023

Uh oh!

gspencergoog Jan 24, 2023

Uh oh!

HansMuller Jan 25, 2023

Uh oh!

gspencergoog Jan 24, 2023

Uh oh!

gspencergoog Jan 24, 2023

Uh oh!

HansMuller Jan 25, 2023

Uh oh!

gspencergoog commented Jan 24, 2023

Uh oh!

guidezpl left a comment

Uh oh!

HansMuller commented Jan 25, 2023

Uh oh!

guidezpl Jan 27, 2023

Uh oh!

guidezpl left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

HansMuller commented Jan 24, 2023

Pre-launch Checklist

Uh oh!

gspencergoog Jan 24, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller Jan 25, 2023

Choose a reason for hiding this comment

Uh oh!

gspencergoog Jan 24, 2023

Choose a reason for hiding this comment

Uh oh!

gspencergoog Jan 24, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller Jan 25, 2023

Choose a reason for hiding this comment

Uh oh!

gspencergoog commented Jan 24, 2023

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller commented Jan 25, 2023

Uh oh!

guidezpl Jan 27, 2023

Choose a reason for hiding this comment

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants