Feat: showDatePicker - Exposed callback when user changes Date Picker Mode #119116
Merged
HansMuller merged 7 commits intoflutter:masterfrom Mar 3, 2023
Merged
Feat: showDatePicker - Exposed callback when user changes Date Picker Mode #119116HansMuller merged 7 commits intoflutter:masterfrom
showDatePicker - Exposed callback when user changes Date Picker Mode #119116HansMuller merged 7 commits intoflutter:masterfrom
Conversation
showDatePicker - Exposed callback when user changes entry mode (Calendar <=> Input )
showDatePicker - Exposed callback when user changes entry mode (Calendar <=> Input )showDatePicker - Exposed callback when user changes Date Picker Mode (Calendar <=> Input )
showDatePicker - Exposed callback when user changes Date Picker Mode (Calendar <=> Input )showDatePicker - Exposed callback when user changes Date Picker Mode
…nput mode, vice verca
…nput mode, vice verca
9a43820 to
a6b11da
Compare
HansMuller
reviewed
Mar 2, 2023
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
This looks great, just noted some small stuff.
Updated the API Doc
Updated the space in if
HansMuller
reviewed
Mar 2, 2023
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Still really close. The presubmit analyze test is complaining about some trailing spaces.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2023
…ate Picker Mode (flutter/flutter#119116)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…ate Picker Mode (flutter/flutter#119116)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…ate Picker Mode (flutter/flutter#119116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed a callback when the user switches between entry mode from calendar to input, this way we can store the preferred input method in the application state and open the next date picker with the preferred entry mode already set (using the existing
initialEntryModeparameter).Fixes #113423
Example of callback
onDatePickerModeChangeScreen Recording
Screen.Recording.2023-01-25.at.11.53.51.AM.mov
CC: @Piinks , @HansMuller
Pre-launch Checklist
///).