Skip to content

Do not run customer testing on release candidate branches. (#119979)#119984

Merged
godofredoc merged 1 commit intoflutter:flutter-3.7-candidate.1from
godofredoc:flutter-3.7-candidate.1
Feb 6, 2023
Merged

Do not run customer testing on release candidate branches. (#119979)#119984
godofredoc merged 1 commit intoflutter:flutter-3.7-candidate.1from
godofredoc:flutter-3.7-candidate.1

Conversation

@godofredoc
Copy link
Contributor

CP: c8e75a8

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

These tests try to use a commit contemporary to the framework commit in
customer repositories. This won't work because a CP to the framework
release candidate branch may be recent even though the release candidate
branch can be months old.
@godofredoc godofredoc requested a review from keyonghan as a code owner February 4, 2023 03:41
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc merged commit 78d09b6 into flutter:flutter-3.7-candidate.1 Feb 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 8, 2023
* 200bc35 Make gen-l10n error handling independent of logger state (#119644) (flutter/flutter#119679)

* 7c28707 cherrypick fix to dwds (flutter/flutter#119745)

* 80f3571 check if directory exists before listing content (#119748) (flutter/flutter#119946)

* 78d09b6 Do not run customer testing on release candidate branches. (#119979) (flutter/flutter#119984)

* c6ab0a0 Cherry pick NavigationBar ink ripple fixes (flutter/flutter#119553)

* 2290856 Verify Mac artifact codesigning on x64 and arm64 (flutter/flutter#120153)

* 32fb2f9 Update Engine revision to f40b73f8a4d5bc2bf50b21e3c0fb478b8f282486 for stable release 3.7.2 (flutter/flutter#120263)
@godofredoc godofredoc deleted the flutter-3.7-candidate.1 branch February 8, 2023 22:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants