Cherry-pick changes to support the use_emulator flag that made it into candidate branch#120305
Conversation
* Round 2 with dimensions * Try with stringified keys * Forgot a comma * trying a list of maps. * Try key value pairs * Try with kvm only * try with swarming_dimensions * Updated with fix in swarming.star * Attempting to remove the bring up property to verify test is running. * Remove android from target tags to avoid adb command automatically running in test_utils call. * Remove the duplicated dependencies in the defines target that exist in the platform
* Testing whether emulator is possible. * Adding changes to see if emulator can be used from recipe. * adding emulator support. * Add the emulator flag for testing. * Using string for boolean since it cannot be parsed in properties * Checking to see if these changes are being used. * Updated bool back to string * Remove trailing whitespace from file.
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
flutter-dashboard
bot
added
the
c: contributor-productivity
|
@ricardoamador this requires a CP request issue to be attached. Please file one at https://github.com/flutter/flutter/issues/new?assignees=&labels=cp%3A+review&template=7_cherry_pick.yml&title=%5BCP%5D+%3Ctitle%3E In the description, include why this is needed, and links to example breakages. |
|
Added a Cherry-pick request. |
|
Landing with failures on codesigning tests as they are not supposed to run/pass on presubmit. |
|
Thanks @godofredoc! |
…ade it into candidate branch (flutter/flutter#120305)
…e it into candidate branch (flutter/flutter#120305)
…e it into candidate branch (flutter/flutter#120305)
3 participants
The Linux_Android android_defines_test is consistently failing on release branches.
For the linux_android defines test the use_emulator flag made it into the release branch however none of the supporting changes did. This cherry-picks two commits that are needed to support the testing with the emulator.
Commits are:
f989d55
22bbdf0
List which issues are fixed by this PR. You must list at least one issue.
Fixes #120287
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.