WIP - Optional portion - 2D framework implementation for review#120623
WIP - Optional portion - 2D framework implementation for review#120623Piinks wants to merge 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: scrolling
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| /// 2. A [TwoDimensionalViewport] widget, which implements the visual design | ||
| /// for scrolling by displaying only a portion | ||
| /// of the widgets inside the scroll view. | ||
| /// 3. A [TwoDimensionalChildDelgate], which provides the children visible in |
There was a problem hiding this comment.
| /// 3. A [TwoDimensionalChildDelgate], which provides the children visible in | |
| /// 3. A [TwoDimensionalChildDelegate], which provides the children visible in |
| /// Returns the child with the given indices. | ||
| /// | ||
| /// Should return null if asked to build a widget with a greater | ||
| /// index than exists. If this returns null, [estimatedChildCount] |
There was a problem hiding this comment.
Does estimatedChildCount still exist? I couldn't find it on this change.
There was a problem hiding this comment.
Oh! That is a bit of copy pasta. Thank you!
|
Closing this to keep it off the triage queue, discussion and feedback is still welcome though. |
3 participants
WIP for discussion in this design document