Enable plugin_test_linux by stuartmorgan-g · Pull Request #120912 · flutter/flutter

stuartmorgan-g · 2023-02-16T20:28:02Z

Enables the new end-to-end Linux desktop plugin tests.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

Enables the new end-to-end Linux desktop plugin tests.

stuartmorgan-g · 2023-02-16T21:38:01Z

@godofredoc do you have any pointers on the

[plugin_test_linux] [STDOUT] stderr: [        ]     error: downloading 'https://github.com/google/googletest/archive/release-1.11.0.zip' failed
[plugin_test_linux] [STDOUT] stderr: [        ]          status_code: 1
[plugin_test_linux] [STDOUT] stderr: [        ]          status_string: "Unsupported protocol"
[plugin_test_linux] [STDOUT] stderr: [        ]          log:
[plugin_test_linux] [STDOUT] stderr: [        ]          --- LOG BEGIN ---
[plugin_test_linux] [STDOUT] stderr: [        ]          Protocol "https" not supported or disabled in libcurl

error here? Do I just need to add the curl dependency in .ci.yaml for this task that I see in some other tasks?

stuartmorgan-g · 2023-03-02T15:51:24Z

@godofredoc Ping on the question above; is a config change all that's needed to make curl work?

godofredoc · 2023-03-02T16:58:22Z

o I just need to add

Yes, let's add it as a dependency to the .ci.yaml file. It will be added automatically to the path. If it doesn't work please ping me a build link to help triage.

Speculative fix for the failure discussed in #120912

stuartmorgan-g · 2023-03-06T16:19:13Z

@godofredoc It's still failing with the same error, unfortunately: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20plugin_test_linux/2/overview

Any idea how we can make this work? I haven't seen a failure like this outside of LUCI.

godofredoc · 2023-03-06T19:43:02Z

@keyonghan FYI

keyonghan · 2023-03-06T22:43:51Z

Will take a look after a P0 issue.

keyonghan · 2023-03-07T21:09:18Z

I can verify that the curl package is installed correctly. Tried curling the referenced url directly as a separate step, it works. See step 8.
https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/4d04910bc7cde441d0cb17572fd7ffe0a52eff4755ef68cc86c90eac33598208/+/build.proto?server=chromium-swarm.appspot.com

@stuartmorgan Do you know how the curl command is executed from the test? By searching around, the Unsupported protocol error happens when things like inappropriate quotes exist.

stuartmorgan-g · 2023-03-07T21:35:54Z

It's run by CMake as part of the build; see https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/plugin/linux.tmpl/CMakeLists.txt.tmpl#L65-L69

Looking around a bit more online now that I know it's only happening with CMake, I found some discussion suggesting that it may have to do with how the installed version of CMake was built and what libcurl it links to. Is this a version we built ourselves?

keyonghan · 2023-03-07T22:02:12Z

We are using the cmake package maintained by chromium team. Seems the current version is super old. We should point to the 3pp one: https://chrome-infra-packages.appspot.com/p/infra/3pp/tools/cmake/linux-amd64/+/M7y24vz-2AFPcsa2WqyEYipISw_SZVSmWMoZQQHsRw4C

Ran an led with latest version from 3pp, it passed the curl error, though the test still fails.
https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/4bf72876ffb69b24ff5c8b2d49227969d6bfaaab4a662b9e4af43bff7ccb8586/+/build.proto?server=chromium-swarm.appspot.com

I will land some quick fixes for the package change.

stuartmorgan-g · 2023-03-07T22:33:41Z

That's just a path mistake in the test code; I can update this PR to fix that tomorrow. Thanks for tracking down the curl problem!

keyonghan · 2023-03-07T23:47:58Z

.ci.yaml

@@ -699,7 +699,6 @@ targets:

  - name: Linux plugin_test_linux


Led run succeeds with the new cmake version: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/d813b8f1ffe0863aff0697eaff6a6e86b51e2a8af06502fcb345af4e7e523afb/+/build.proto?server=chromium-swarm.appspot.com

Updating the cmake version to version:[email protected] should pass the CI.

Great! That has to be a separate PR that lands and then propagates I assume, like other ci.yaml changes?

Presubmit CI will pick up the changes right away, so changes in this same PR will work.

Please allow https://flutter-review.googlesource.com/c/recipes/+/40060 to land before pushing the change, as the infra config complains about the special character @ in the version: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20ci_yaml%20flutter%20roller/2119/overview.

After the above CL lands, please use version build_id:8787856497187628321 instead of version:[email protected].
(successful led run with version build_id:8787856497187628321: :https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/9a8f995890c8aa1dd97b86de8a5f3a2018dcce8050fcc2f2143d6b6569aa0e5c/+/build.proto?server=chromium-swarm.appspot.com)

Presubmit CI will pick up the changes right away, so changes in this same PR will work.

Ah, nice. Is there a list somewhere of what does and doesn't work in-PR? I know that timeout changes don't take effect right away, for instance, having been bitten by that before, but I'm not clear on what things do.

All properties should be picked up right away. Updated flutter/cocoon#2519 to make it clear.

keyonghan · 2023-03-08T21:03:15Z

cmake was bundle updated in #122147. A rebase should green the CI.

keyonghan

LGTM

stuartmorgan-g · 2023-03-09T00:40:57Z

Thanks for all the help with resolving the blocker!

Enable plugin_test_linux

Enable plugin_tests_linux

c30b1f6

Enables the new end-to-end Linux desktop plugin tests.

stuartmorgan-g requested a review from keyonghan as a code owner February 16, 2023 20:28

stuartmorgan-g mentioned this pull request Mar 2, 2023

Add curl dependency to plugin_test_linux #121807

Merged

stuartmorgan-g changed the title ~~Enable plugin_tests_linux~~ Enable plugin_test_linux Mar 2, 2023

stuartmorgan-g added a commit that referenced this pull request Mar 2, 2023

Add curl dependency to plugin_test_linux

0c344ce

Speculative fix for the failure discussed in #120912

Merge branch 'master' into enable-plugins-linux

faba159

keyonghan mentioned this pull request Mar 7, 2023

Update package cmake to latest 3pp version #122138

Closed

3 tasks

Fix binary path

ea6677a

keyonghan reviewed Mar 7, 2023

View reviewed changes

keyonghan mentioned this pull request Mar 8, 2023

Update CI_YAML.MD regarding taget updates flutter/cocoon#2519

Merged

Merge branch 'master' into enable-plugins-linux

89ba21d

keyonghan approved these changes Mar 8, 2023

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023

auto-submit bot merged commit 449a5bc into flutter:master Mar 9, 2023

engine-flutter-autoroll mentioned this pull request Mar 9, 2023

Roll Flutter from 5a279edc239f to c5da5070f10e (32 revisions) flutter/packages#3429

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

06218d7

engine-flutter-autoroll mentioned this pull request Mar 10, 2023

Roll Flutter from 5a279edc239f to 1f426123230b (53 revisions) flutter/packages#3437

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

10460f2

engine-flutter-autoroll mentioned this pull request Mar 10, 2023

Roll Flutter from 5a279edc239f to e98c53751ef9 (55 revisions) flutter/packages#3440

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

2abf973

engine-flutter-autoroll mentioned this pull request Mar 10, 2023

Roll Flutter from 5a279edc239f to 3f2cca8eebfd (56 revisions) flutter/packages#3441

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

92eda07

hannah-hyj pushed a commit to hannah-hyj/flutter that referenced this pull request Mar 11, 2023

Enable plugin_test_linux (flutter#120912)

03c73eb

Enable plugin_test_linux

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

3c9df93

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

39346ed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

8d84b96

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

449a5bc Enable plugin_test_linux (flutter/flutter#120912)

a8036cb

Conversation

stuartmorgan-g commented Feb 16, 2023

Pre-launch Checklist

Uh oh!

stuartmorgan-g commented Feb 16, 2023

Uh oh!

stuartmorgan-g commented Mar 2, 2023

Uh oh!

godofredoc commented Mar 2, 2023

Uh oh!

stuartmorgan-g commented Mar 6, 2023

Uh oh!

godofredoc commented Mar 6, 2023

Uh oh!

keyonghan commented Mar 6, 2023

Uh oh!

keyonghan commented Mar 7, 2023

Uh oh!

stuartmorgan-g commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keyonghan commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Mar 7, 2023

Uh oh!

keyonghan Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonghan Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

keyonghan Mar 8, 2023

Choose a reason for hiding this comment

Uh oh!

keyonghan commented Mar 8, 2023

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stuartmorgan-g commented Mar 7, 2023 •

edited

Loading

keyonghan commented Mar 7, 2023 •

edited

Loading

stuartmorgan-g Mar 8, 2023 •

edited

Loading